Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1437)

Unified Diff: content/public/browser/resource_dispatcher_host.h

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix typos Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/browser/resource_dispatcher_host.h
diff --git a/content/public/browser/resource_dispatcher_host.h b/content/public/browser/resource_dispatcher_host.h
index 7ad7631beeb80459346175520f50a5c272277155..49366749251c54b5cd11e182ea8fd048c8764548 100644
--- a/content/public/browser/resource_dispatcher_host.h
+++ b/content/public/browser/resource_dispatcher_host.h
@@ -9,7 +9,7 @@
#include "base/callback_forward.h"
#include "base/memory/scoped_ptr.h"
-#include "content/public/browser/download_interrupt_reasons.h"
+#include "content/common/content_export.h"
namespace net {
class URLRequest;
@@ -26,9 +26,6 @@ class RenderFrameHost;
class CONTENT_EXPORT ResourceDispatcherHost {
public:
- typedef base::Callback<void(DownloadItem*, DownloadInterruptReason)>
- DownloadStartedCallback;
-
// Returns the singleton instance of the ResourceDispatcherHost.
static ResourceDispatcherHost* Get();
@@ -50,30 +47,6 @@ class CONTENT_EXPORT ResourceDispatcherHost {
// dialog boxes.
virtual void SetAllowCrossOriginAuthPrompt(bool value) = 0;
- // Initiates a download by explicit request of the renderer (e.g. due to
- // alt-clicking a link) or some other chrome subsystem.
- // |is_content_initiated| is used to indicate that the request was generated
- // from a web page, and hence may not be as trustworthy as a browser
- // generated request. If |download_id| is invalid, a download id will be
- // automatically assigned to the request, otherwise the specified download id
- // will be used. (Note that this will result in re-use of an existing
- // download item if the download id was already assigned.) If the download
- // is started, |started_callback| will be called on the UI thread with the
- // DownloadItem; otherwise an interrupt reason will be returned.
- virtual DownloadInterruptReason BeginDownload(
- scoped_ptr<net::URLRequest> request,
- const Referrer& referrer,
- bool is_content_initiated,
- ResourceContext* context,
- int child_id,
- int render_view_route_id,
- int render_frame_route_id,
- bool prefer_cache,
- bool do_not_prompt_for_login,
- scoped_ptr<DownloadSaveInfo> save_info,
- uint32_t download_id,
- const DownloadStartedCallback& started_callback) = 0;
-
// Clears the ResourceDispatcherHostLoginDelegate associated with the request.
virtual void ClearLoginDelegateForRequest(net::URLRequest* request) = 0;
« no previous file with comments | « content/public/browser/download_url_parameters.h ('k') | content/public/test/test_download_request_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698