content/browser/loader/mime_type_resource_handler.cc - Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/mime_type_resource_handler.cc

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix typos Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/loader/mime_type_resource_handler.cc

diff --git a/content/browser/loader/mime_type_resource_handler.cc b/content/browser/loader/mime_type_resource_handler.cc

index 3c69c0ad4d2c9f644a7697cdf27652d4ed7e539b..c9a9bb89be39254ca2bc9151a68a7b49b47a9141 100644

--- a/content/browser/loader/mime_type_resource_handler.cc

+++ b/content/browser/loader/mime_type_resource_handler.cc

@@ -385,13 +385,9 @@ bool MimeTypeResourceHandler::SelectNextHandler(bool* defer) {

// Install download handler

info->set_is_download(true);

scoped_ptr<ResourceHandler> handler(

- host_->CreateResourceHandlerForDownload(

- request(),

- true, // is_content_initiated

- must_download,

- DownloadItem::kInvalidId,

- scoped_ptr<DownloadSaveInfo>(new DownloadSaveInfo()),

- DownloadUrlParameters::OnStartedCallback()));

+ host_->CreateResourceHandlerForDownload(request(),

+ true, // is_content_initiated

+ must_download));

return UseAlternateNextHandler(std::move(handler), std::string());

}