content/browser/download/drag_download_file.cc - Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/drag_download_file.cc

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix typos Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/drag_download_file.cc

diff --git a/content/browser/download/drag_download_file.cc b/content/browser/download/drag_download_file.cc

index afb533a56bf74dd30e68ba73f3f35185b55f2c4b..dc6b89c8b8f56bdca61a13d634b771e03ff78d16 100644

--- a/content/browser/download/drag_download_file.cc

+++ b/content/browser/download/drag_download_file.cc

@@ -97,8 +97,8 @@ class DragDownloadFile::DragDownloadFileUI : public DownloadItem::Observer {

void OnDownloadStarted(DownloadItem* item,

DownloadInterruptReason interrupt_reason) {

DCHECK_CURRENTLY_ON(BrowserThread::UI);

- if (!item) {

- DCHECK_NE(DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason);

+ if (!item || item->GetState() != DownloadItem::IN_PROGRESS) {

+ DCHECK(!item || item->GetLastReason() != DOWNLOAD_INTERRUPT_REASON_NONE);

on_completed_loop_->task_runner()->PostTask(

FROM_HERE, base::Bind(on_completed_, false));

return;