Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1503)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/webstore_installer.cc

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment updates Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/download/download_target_determiner.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/test/data/downloads/download-anchor-attrib-400.html » ('j') | content/browser/download/download_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/webstore_installer.cc
diff --git a/chrome/browser/extensions/webstore_installer.cc b/chrome/browser/extensions/webstore_installer.cc
index a97ec7699e4d9ec41657ab29a8fa2220e046f9c1..fa910f3ee4c998cec017007219b4544b67fb6b86 100644
--- a/chrome/browser/extensions/webstore_installer.cc
+++ b/chrome/browser/extensions/webstore_installer.cc
@@ -459,8 +459,9 @@ void WebstoreInstaller::OnDownloadStarted(
const std::string& extension_id,
DownloadItem* item,
content::DownloadInterruptReason interrupt_reason) {
- if (!item) {
- DCHECK_NE(content::DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason);
+ if (!item || interrupt_reason != content::DOWNLOAD_INTERRUPT_REASON_NONE) {
+ if (item)
+ item->Remove();
ReportFailure(content::DownloadInterruptReasonToString(interrupt_reason),
FAILURE_REASON_OTHER);
return;
« chrome/browser/download/download_target_determiner.cc ('K') | « chrome/browser/extensions/api/downloads/downloads_api_browsertest.cc ('k') | chrome/test/data/downloads/download-anchor-attrib-400.html » ('j') | content/browser/download/download_browsertest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698