Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/extensions/api/downloads/downloads_api.cc

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment updates Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/downloads/downloads_api.cc
diff --git a/chrome/browser/extensions/api/downloads/downloads_api.cc b/chrome/browser/extensions/api/downloads/downloads_api.cc
index 0a297d2116bd4a67bd2bed82ea1b9fbfa9a1556f..c8fc9921f1a7da08effe28cd23b0bc691ee5a2cd 100644
--- a/chrome/browser/extensions/api/downloads/downloads_api.cc
+++ b/chrome/browser/extensions/api/downloads/downloads_api.cc
@@ -1038,7 +1038,6 @@ void DownloadsDownloadFunction::OnStarted(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
VLOG(1) << __FUNCTION__ << " " << item << " " << interrupt_reason;
if (item) {
- DCHECK_EQ(content::DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason);
SetResult(new base::FundamentalValue(static_cast<int>(item->GetId())));
if (!creator_suggested_filename.empty() ||
(creator_conflict_action !=
@@ -1056,7 +1055,6 @@ void DownloadsDownloadFunction::OnStarted(
new DownloadedByExtension(item, extension()->id(), extension()->name());
item->UpdateObservers();
} else {
- DCHECK_NE(content::DOWNLOAD_INTERRUPT_REASON_NONE, interrupt_reason);
error_ = content::DownloadInterruptReasonToString(interrupt_reason);
}
SendResponse(error_.empty());

Powered by Google App Engine
This is Rietveld 408576698