Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: content/browser/loader/resource_dispatcher_host_impl.h

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/resource_dispatcher_host_impl.h
diff --git a/content/browser/loader/resource_dispatcher_host_impl.h b/content/browser/loader/resource_dispatcher_host_impl.h
index 29a82b248a109c7890fec7e0c2f5b6d2ff717d4c..c71bbbdb592487c54a796686a260c0236dfb650c 100644
--- a/content/browser/loader/resource_dispatcher_host_impl.h
+++ b/content/browser/loader/resource_dispatcher_host_impl.h
@@ -91,19 +91,6 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
// ResourceDispatcherHost implementation:
void SetDelegate(ResourceDispatcherHostDelegate* delegate) override;
void SetAllowCrossOriginAuthPrompt(bool value) override;
- DownloadInterruptReason BeginDownload(
- scoped_ptr<net::URLRequest> request,
- const Referrer& referrer,
- bool is_content_initiated,
- ResourceContext* context,
- int child_id,
- int render_view_route_id,
- int render_frame_route_id,
- bool prefer_cache,
- bool do_not_prompt_for_login,
- scoped_ptr<DownloadSaveInfo> save_info,
- uint32_t download_id,
- const DownloadStartedCallback& started_callback) override;
void ClearLoginDelegateForRequest(net::URLRequest* request) override;
void BlockRequestsForRoute(int child_id, int route_id) override;
void ResumeBlockedRequestsForRoute(int child_id, int route_id) override;
@@ -127,6 +114,15 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
bool OnMessageReceived(const IPC::Message& message,
ResourceMessageFilter* filter);
+ DownloadInterruptReason BeginDownload(scoped_ptr<net::URLRequest> request,
+ const Referrer& referrer,
+ bool is_content_initiated,
+ ResourceContext* context,
+ int child_id,
+ int render_view_route_id,
+ int render_frame_route_id,
+ bool do_not_prompt_for_login);
+
// Initiates a save file from the browser process (as opposed to a resource
// request from the renderer or another child process).
void BeginSaveFile(const GURL& url,
@@ -228,10 +224,7 @@ class CONTENT_EXPORT ResourceDispatcherHostImpl
virtual scoped_ptr<ResourceHandler> CreateResourceHandlerForDownload(
net::URLRequest* request,
bool is_content_initiated,
- bool must_download,
- uint32_t id,
- scoped_ptr<DownloadSaveInfo> save_info,
- const DownloadUrlParameters::OnStartedCallback& started_cb);
+ bool must_download);
// Called to determine whether the response to |request| should be intercepted
// and handled as a stream. Streams are used to pass direct access to a

Powered by Google App Engine
This is Rietveld 408576698