[Downloads] Always call DM::StartDownload() for explicit downloads.

content/browser/download/download_create_info.cc

Index: content/browser/download/download_create_info.cc
diff --git a/content/browser/download/download_create_info.cc b/content/browser/download/download_create_info.cc
index c09d713aa9705271d9340d281e46b3c9151953f3..368f87eb97a9c04e861b86349ed88f9ecd31e841 100644
--- a/content/browser/download/download_create_info.cc
+++ b/content/browser/download/download_create_info.cc
@@ -5,7 +5,6 @@
 #include "content/browser/download/download_create_info.h"
 
 #include <string>
-#include <utility>
 
 #include "base/format_macros.h"
 #include "base/strings/stringprintf.h"
@@ -13,20 +12,19 @@
 namespace content {
 
 DownloadCreateInfo::DownloadCreateInfo(const base::Time& start_time,
-                                       int64_t total_bytes,
                                        const net::BoundNetLog& bound_net_log,
                                        scoped_ptr<DownloadSaveInfo> save_info)
-    : start_time(start_time),
-      total_bytes(total_bytes),
-      download_id(DownloadItem::kInvalidId),
+    : download_id(DownloadItem::kInvalidId),
+      start_time(start_time),
       has_user_gesture(false),
       transition_type(ui::PAGE_TRANSITION_LINK),
+      result(DOWNLOAD_INTERRUPT_REASON_NONE),
       save_info(std::move(save_info)),
-      request_bound_net_log(bound_net_log) {}
+      request_bound_net_log(bound_net_log),
+      total_bytes(0) {}

[Randy Smith (Not in Mondays), 2016/02/10 21:48:45]

Codesearch can't find a place where this is read or set in the current codebase,
and I can't find anywhere where it's read in your CL (though I did see it being
set below).  Can we just delete this data member?

[asanka, 2016/02/11 03:43:07]

It's set based on the Content-Length of the response and is read by the
DownloadItemImpl constructor. CodeSearch may have had a temporary hiccup. It's
showing both references now.

 
 DownloadCreateInfo::DownloadCreateInfo()
     : DownloadCreateInfo(base::Time(),
-                         0,
                          net::BoundNetLog(),
                          make_scoped_ptr(new DownloadSaveInfo)) {}