Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Unified Diff: content/browser/download/download_resource_handler.h

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_resource_handler.h
diff --git a/content/browser/download/download_resource_handler.h b/content/browser/download/download_resource_handler.h
index 2c1d4777b39cbbe92bd234f7f823ea2a40ee0961..fa5c2f36dc8d44087e05316ca09e41800a9d619e 100644
--- a/content/browser/download/download_resource_handler.h
+++ b/content/browser/download/download_resource_handler.h
@@ -97,11 +97,11 @@ class CONTENT_EXPORT DownloadResourceHandler
private:
virtual ~DownloadResourceHandler();
- // Arrange for started_cb_ to be called on the UI thread with the
- // below values, nulling out started_cb_. Should only be called
- // on the IO thread.
- void CallStartedCB(DownloadItem* item,
- DownloadInterruptReason interrupt_reason);
+ void NotifyDownloadManagerOfSuccessfulResponseStart(
+ ResourceResponse* response);
+
+ void NotifyDownloadManagerOfFailedRequest(
+ DownloadInterruptReason interrupt_reason);
uint32 download_id_;
// This is read only on the IO thread, but may only
@@ -125,7 +125,7 @@ class CONTENT_EXPORT DownloadResourceHandler
bool was_deferred_;
// For DCHECKing
- bool on_response_started_called_;
+ bool download_manager_notified_;
static const int kReadBufSize = 32768; // bytes
static const int kThrottleTimeMs = 200; // milliseconds

Powered by Google App Engine
This is Rietveld 408576698