Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Unified Diff: content/browser/download/download_file_factory.cc

Issue 148133007: [Downloads] Always call DM::StartDownload() for explicit downloads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_file_factory.cc
diff --git a/content/browser/download/download_file_factory.cc b/content/browser/download/download_file_factory.cc
index a7fe7b834a9933d3becdad72bf7339917c8f4254..ee7883d842583dd0c61b76a881982113abccba5b 100644
--- a/content/browser/download/download_file_factory.cc
+++ b/content/browser/download/download_file_factory.cc
@@ -12,12 +12,13 @@ namespace content {
DownloadFileFactory::~DownloadFileFactory() {}
DownloadFile* DownloadFileFactory::CreateFile(
- scoped_ptr<DownloadSaveInfo> save_info,
+ const DownloadSaveInfo& save_info,
const base::FilePath& default_downloads_directory,
const GURL& url,
const GURL& referrer_url,
bool calculate_hash,
- scoped_ptr<ByteStreamReader> stream,
+ scoped_ptr<net::FileStream> file_stream,
+ scoped_ptr<ByteStreamReader> byte_stream,
const net::BoundNetLog& bound_net_log,
base::WeakPtr<DownloadDestinationObserver> observer) {
scoped_ptr<PowerSaveBlocker> psb(
@@ -25,8 +26,8 @@ DownloadFile* DownloadFileFactory::CreateFile(
PowerSaveBlocker::kPowerSaveBlockPreventAppSuspension,
"Download in progress"));
return new DownloadFileImpl(
- save_info.Pass(), default_downloads_directory, url, referrer_url,
- calculate_hash, stream.Pass(), bound_net_log,
+ save_info, default_downloads_directory, url, referrer_url,
+ calculate_hash, file_stream.Pass(), byte_stream.Pass(), bound_net_log,
psb.Pass(), observer);
}

Powered by Google App Engine
This is Rietveld 408576698