[Downloads] Always call DM::StartDownload() for explicit downloads.

chrome/browser/download/download_target_determiner_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/at_exit.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/message_loop/message_loop.h"
 #include "base/observer_list.h"
 #include "base/prefs/pref_service.h"
@@ skipping 905 matching lines @@
 // Test that an inactive download will still get a virtual or local download
 // path.
 TEST_F(DownloadTargetDeterminerTest, TargetDeterminer_InactiveDownload) {
   const DownloadTestCase kInactiveTestCases[] = {
     {
       AUTOMATIC,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
       "http://example.com/foo.txt", "text/plain",
       FILE_PATH_LITERAL(""),
 
-      FILE_PATH_LITERAL(""),
+      FILE_PATH_LITERAL("foo.txt"),
       DownloadItem::TARGET_DISPOSITION_OVERWRITE,
 
-      EXPECT_LOCAL_PATH
+      EXPECT_CRDOWNLOAD
     },
 
     {
       SAVE_AS,
       content::DOWNLOAD_DANGER_TYPE_NOT_DANGEROUS,
       "http://example.com/foo.txt", "text/plain",
       FILE_PATH_LITERAL(""),
 
-      FILE_PATH_LITERAL(""),
+      FILE_PATH_LITERAL("foo.txt"),
       DownloadItem::TARGET_DISPOSITION_PROMPT,
 
-      EXPECT_LOCAL_PATH
+      EXPECT_CRDOWNLOAD
     }
   };
 
   for (size_t i = 0; i < arraysize(kInactiveTestCases); ++i) {
     SCOPED_TRACE(testing::Message() << "Running test case " << i);
     const DownloadTestCase& test_case = kInactiveTestCases[i];
     scoped_ptr<content::MockDownloadItem> item(
         CreateActiveDownloadItem(i, test_case));
     EXPECT_CALL(*item.get(), GetState())
         .WillRepeatedly(Return(content::DownloadItem::CANCELLED));
-    // Even though one is a SAVE_AS download, no prompt will be displayed to
-    // the user because the download is inactive.
-    EXPECT_CALL(*delegate(), PromptUserForDownloadPath(_, _, _))
-        .Times(0);
+
+    // The following delegate methods should not be invoked for an inactive
+    // download.
+    EXPECT_CALL(*delegate(), PromptUserForDownloadPath(_, _, _)).Times(0);
+    EXPECT_CALL(*delegate(), NotifyExtensions(_, _, _)).Times(0);
+    EXPECT_CALL(*delegate(), ReserveVirtualPath(_, _, _, _, _)).Times(0);
+    EXPECT_CALL(*delegate(), DetermineLocalPath(_, _, _)).Times(1);
     RunTestCase(test_case, base::FilePath(), item.get());
   }
 }
 
 // If the reserved path could not be verified, then the user should see a
 // prompt.
 TEST_F(DownloadTargetDeterminerTest, TargetDeterminer_ReservationFailed) {
   const DownloadTestCase kReservationFailedCases[] = {
     {
       // 0: Automatic download. Since the reservation fails, the disposition of
@@ skipping 1213 matching lines @@
   EXPECT_CALL(mock_plugin_filter_, MockPluginAvailable(npapi_plugin.path()))
       .WillRepeatedly(Return(true));
 
   target_info = RunDownloadTargetDeterminer(
       GetPathInDownloadDir(kInitialPath), item.get());
   EXPECT_FALSE(target_info->is_filetype_handled_safely);
 }
 #endif  // defined(ENABLE_PLUGINS)
 
 }  // namespace