lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp - Issue 14813032: Make abbreviations explicit in pnacl-freeze/thaw.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp

Issue 14813032: Make abbreviations explicit in pnacl-freeze/thaw. (Closed) Base URL: http://git.chromium.org/native_client/pnacl-llvm.git@master

Patch Set: Fix code based on Jan's suggestions. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp

diff --git a/lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp b/lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp

index 677539071b7c066b9b7ab48ba1df2bf5bb487f9b..d75c42ca9bf282ab9f3f4505821d2d88e18166bf 100644

--- a/lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp

+++ b/lib/Bitcode/NaCl/Reader/NaClBitstreamReader.cpp

@@ -71,13 +71,14 @@ bool NaClBitstreamCursor::EnterSubBlock(unsigned BlockID, unsigned *NumWordsP) {

}

// Get the codesize of this block.

- CurCodeSize = ReadVBR(naclbitc::CodeLenWidth);

+ CurCodeSize.IsFixed = true;

+ CurCodeSize.NumBits = ReadVBR(naclbitc::CodeLenWidth);

SkipToFourByteBoundary();

unsigned NumWords = Read(naclbitc::BlockSizeWidth);

if (NumWordsP) *NumWordsP = NumWords;

// Validate that this block is sane.

- if (CurCodeSize == 0 || AtEndOfStream())

+ if (CurCodeSize.NumBits == 0 || AtEndOfStream())

return true;

return false;