Issue 14813026: Support android as a target platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14813026: Support android as a target platform. (Closed)

Created:
7 years, 7 months ago by Torne

Modified:
7 years, 7 months ago

Reviewers:
Jói, newt (away)

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Visibility:
Public.

More Reviews

Description

Support android as a target platform. Provide an is_android condition, and set is_posix to true when the target platform is android to match the OS_* defines in Chromium. grit_info didn't previously support -t to set the target platform, so add that as well. BUG=chromium:239434

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -5 lines)			Patch
	M	grit/node/base.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	grit_info.py	View		3 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Torne

Hi Newt, Jói, This change to grit allows "-t android" to work to set the ...

7 years, 7 months ago (2013-05-14 11:23:43 UTC) #1

Torne

Also, I'm not a grit committer so if this is okay can one of you ...

7 years, 7 months ago (2013-05-14 11:26:03 UTC) #2

Jói

7 years, 7 months ago (2013-05-14 18:09:26 UTC) #5

On 2013/05/14 18:09:09, Jói wrote:
> LGTM

Will land this for you in a sec.

Expand Messages | Collapse Messages