Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Unified Diff: Source/WebKit/chromium/src/WebViewImpl.h

Issue 14813025: Refactor viewport initialization logic out of WebViewImpl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address code review comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebViewImpl.h
diff --git a/Source/WebKit/chromium/src/WebViewImpl.h b/Source/WebKit/chromium/src/WebViewImpl.h
index 12f592213255f428f07332c20a77def3296cfca5..24aa4ef28921a9d47f9a22b454a55f1e0e19e6af 100644
--- a/Source/WebKit/chromium/src/WebViewImpl.h
+++ b/Source/WebKit/chromium/src/WebViewImpl.h
@@ -41,6 +41,7 @@
#include "PageOverlayList.h"
#include "PageWidgetDelegate.h"
#include "UserMediaClientImpl.h"
+#include "ViewportAttributesManager.h"
#include "WebInputEvent.h"
#include "WebNavigationPolicy.h"
#include "WebView.h"
@@ -226,7 +227,6 @@ public:
double maximumZoomLevel);
virtual void setInitialPageScaleOverride(float);
virtual float pageScaleFactor() const;
- virtual bool isPageScaleFactorSet() const;
virtual void setPageScaleFactorPreservingScrollOffset(float);
virtual void setPageScaleFactor(float scaleFactor, const WebPoint& origin);
virtual void setPageScaleFactorLimits(float minPageScale, float maxPageScale);
@@ -235,7 +235,7 @@ public:
virtual void saveScrollAndScaleState();
virtual void restoreScrollAndScaleState();
virtual void resetScrollAndScaleState();
- virtual void setIgnoreViewportTagMaximumScale(bool);
+ virtual void setIgnoreViewportTagScaleLimits(bool);
virtual float deviceScaleFactor() const;
virtual void setDeviceScaleFactor(float);
@@ -466,8 +466,7 @@ public:
return m_emulatedTextZoomFactor;
}
- void setInitialPageScaleFactor(float initialPageScaleFactor) { m_initialPageScaleFactor = initialPageScaleFactor; }
- bool ignoreViewportTagMaximumScale() const { return m_ignoreViewportTagMaximumScale; }
+ void updatePageDefinedViewportConstraints(const WebCore::ViewportArguments&);
// Determines whether a page should e.g. be opened in a background tab.
// Returns false if it has no opinion, in which case it doesn't set *policy.
@@ -594,9 +593,10 @@ public:
WebSettingsImpl* settingsImpl();
private:
- void computePageScaleFactorLimits();
- float clampPageScaleFactorToLimits(float scale);
- WebCore::IntPoint clampOffsetAtScale(const WebCore::IntPoint& offset, float scale) const;
+ void refreshPageScaleFactorAfterLayout();
+ void setUserAgentViewportConstraints(WebCore::ViewportAttributes newConstraints);
+ float clampPageScaleFactorToLimits(float) const;
+ WebCore::IntPoint clampOffsetAtScale(const WebCore::IntPoint& offset, float scale);
WebCore::IntSize contentsSize() const;
void resetSavedScrollAndScaleState();
@@ -726,15 +726,7 @@ private:
double m_maximumZoomLevel;
- // State related to the page scale
- float m_pageDefinedMinimumPageScaleFactor;
- float m_pageDefinedMaximumPageScaleFactor;
- float m_minimumPageScaleFactor;
- float m_maximumPageScaleFactor;
- float m_initialPageScaleFactorOverride;
- float m_initialPageScaleFactor;
- bool m_ignoreViewportTagMaximumScale;
- bool m_pageScaleFactorIsSet;
abarth-chromium 2013/05/13 18:22:24 Thank you!!
+ ViewportAttributesManager m_viewportAttributesManager;
// Saved page scale state.
float m_savedPageScaleFactor; // 0 means that no page scale factor is saved.

Powered by Google App Engine
This is Rietveld 408576698