add SkString::append(const char c)

add SkString::append(const char c)

R=bsalomon@google.com

Committed: https://code.google.com/p/skia/source/detail?r=9081

[epoger, 2013-05-09 18:54:21]

Brian, Leon, and I agreed yesterday that this would be handy.

[bsalomon, 2013-05-09 18:58:28]

lgtm

[epoger, 2013-05-09 19:37:44]

Committed patchset #1 manually as r9081 (presubmit successful).

[bungeman-skia, 2013-05-09 19:47:17]

I don't see the need for this at all, this is what appendUnichar is for. It
seems like API bloat to have two methods which essentially do the same thing,
but this new guy doesn't make it very clear that the 'char' needs to be utf-8 to
play nicely. (Of course neither do the 'char[]' ones, but aside from that...)

[epoger, 2013-05-09 19:53:05]

On 2013/05/09 19:47:17, bungeman1 wrote:
> I don't see the need for this at all, this is what appendUnichar is for. It
> seems like API bloat to have two methods which essentially do the same thing,
> but this new guy doesn't make it very clear that the 'char' needs to be utf-8
to
> play nicely. (Of course neither do the 'char[]' ones, but aside from that...)

Context: the SkString methods in question are around here:
https://code.google.com/p/skia/source/browse/trunk/include/core/SkString.h?r=...

In this case, I didn't want to append a SkUnichar; I wanted to append
SkPATH_SEPARATOR, which is defined here as a char...
https://code.google.com/p/skia/source/browse/trunk/include/core/SkOSFile.h?r=...

So, what's the best way to append SkPATH_SEPARATOR to an SkString?

[reed1, 2013-05-09 19:55:56]

On 2013/05/09 19:53:05, epoger wrote:
> On 2013/05/09 19:47:17, bungeman1 wrote:
> > I don't see the need for this at all, this is what appendUnichar is for. It
> > seems like API bloat to have two methods which essentially do the same
thing,
> > but this new guy doesn't make it very clear that the 'char' needs to be
utf-8
> to
> > play nicely. (Of course neither do the 'char[]' ones, but aside from
that...)
> 
> Context: the SkString methods in question are around here:
>
https://code.google.com/p/skia/source/browse/trunk/include/core/SkString.h?r=...
> 
> In this case, I didn't want to append a SkUnichar; I wanted to append
> SkPATH_SEPARATOR, which is defined here as a char...
>
https://code.google.com/p/skia/source/browse/trunk/include/core/SkOSFile.h?r=...
> 
> So, what's the best way to append SkPATH_SEPARATOR to an SkString?

Use appendUnichar(SkPATH_SEPARATOR).

The problem possibly w/ this change is that we can make non-utf8 sequences.

I would also like to undo this cl

[epoger, 2013-05-09 19:57:29]

On 2013/05/09 19:55:56, reed1 wrote:
> > So, what's the best way to append SkPATH_SEPARATOR to an SkString?
> 
> Use appendUnichar(SkPATH_SEPARATOR).
> 
> The problem possibly w/ this change is that we can make non-utf8 sequences.

Isn't that already an issue with the existing append() and += operators?

At any rate, OK, I'll roll this out and use appendUnichar() instead for my case.