Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1481273002: Consistently use implements when one interface inherits from another interface (Closed)

Created:
5 years ago by Brian Wilkerson
Modified:
5 years ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Consistently use implements when one interface inherits from another interface R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/86216e5154970a9d34ca7ca012f396909c90a1fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/protocol/protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/file_system/file_system.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
5 years ago (2015-11-29 17:10:47 UTC) #2
scheglov
LGTM
5 years ago (2015-11-29 17:15:26 UTC) #3
Brian Wilkerson
5 years ago (2015-11-30 15:58:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86216e5154970a9d34ca7ca012f396909c90a1fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698