Componentize the bad clock blocking page

components/security_interstitials/core/controller_client.h

Index: components/security_interstitials/core/controller_client.h
diff --git a/components/security_interstitials/core/controller_client.h b/components/security_interstitials/core/controller_client.h
index 6eb41e0b59e3fd519598693b4dd727b4de54d382..ef652730f26840d88b8ceb8940abffa42afdef43 100644
--- a/components/security_interstitials/core/controller_client.h
+++ b/components/security_interstitials/core/controller_client.h
@@ -9,14 +9,13 @@
 
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
+#include "components/security_interstitials/core/metrics_helper.h"

[estark, 2015/12/01 18:40:17]

why can't this be forward-declared?

[felt, 2015/12/01 19:13:45]

Done.

 
 class GURL;
 class PrefService;
 
 namespace security_interstitials {
 
-class MetricsHelper;
-
 // Constants used to communicate with the JavaScript.
 extern const char kBoxChecked[];
 extern const char kDisplayCheckBox[];
@@ -51,7 +50,8 @@ enum SecurityInterstitialCommands {
 };
 
 // Provides methods for handling commands from the user, which requires some
-// embedder-specific abstraction.
+// embedder-specific abstraction. This class should handle all commands sent
+// by the JavaScript error page.
 class ControllerClient {
  public:
   ControllerClient();
@@ -61,6 +61,13 @@ class ControllerClient {
   void SetReportingPreference(bool report);
   void OpenExtendedReportingPrivacyPolicy();
 
+  // If available, open the operating system's date/time settings.
+  virtual bool CanLaunchDateAndTimeSettings() = 0;
+  virtual void LaunchDateAndTimeSettings() = 0;
+
+  // Close the error and go back to the previous page.
+  virtual void GoBack() = 0;
+
   MetricsHelper* metrics_helper() const;
   void set_metrics_helper(scoped_ptr<MetricsHelper> metrics_helper);