Componentize the bad clock blocking page

components/security_interstitials/core/common_string_util.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_SECURITY_INTERSTITIALS_CORE_COMMON_STRING_UTIL_H_
+#define COMPONENTS_SECURITY_INTERSTITIALS_CORE_COMMON_STRING_UTIL_H_
+
+#include "base/macros.h"
+#include "base/time/time.h"
+#include "base/values.h"
+#include "net/ssl/ssl_info.h"
+#include "url/gurl.h"
+
+namespace security_interstitials {
+
+// This namespace contains shared functionality for manipulating the strings
+// and string resources in security error pages.
+namespace common_string_util {
+
+// Returns the |gurl| as a URL appropriate for display in an error page.
+base::string16 GetFormattedHostName(const GURL& gurl,

[Peter Kasting, 2015/12/02 01:14:40]

We should also be using this in
CaptivePortalBlockingPage::PopulateInterstitialStrings().

Should we also be using this in LocalizedError::GetStrings()?

[felt, 2015/12/02 03:30:38]

Yes, I'm going to go through each of the BlockingPages one at a time and convert
them in the same manner (using all of the methods here).
That's a good idea. I will see in a follow-up CL how much code could be shared
with LocalizedError.

+                                    const std::string& languages);
+
+// For SSL-related errors that share a basic structure.
+void PopulateSSLLayoutStrings(int cert_error,
+                              base::DictionaryValue* load_time_data);
+
+// For SSL-related errors that provide debugging information.
+void PopulateSSLDebuggingStrings(const net::SSLInfo ssl_info,
+                                 const base::Time time_triggered,
+                                 base::DictionaryValue* load_time_data);
+
+}  // common_string_util
+
+}  // namespace security_interstitials
+
+#endif  // COMPONENTS_SECURITY_INTERSTITIALS_CORE_COMMON_STRING_UTIL_H_