Componentize the bad clock blocking page

components/security_interstitials/core/common_string_util.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/security_interstitials/core/common_string_util.h"
+
+#include "base/i18n/rtl.h"
+#include "base/i18n/time_formatting.h"
+#include "base/strings/string_util.h"
+#include "components/url_formatter/url_formatter.h"
+#include "grit/components_strings.h"
+#include "net/base/net_errors.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace security_interstitials {
+
+namespace common_string_util {
+
+base::string16 GetFormattedHostName(const GURL& gurl,
+                                    const std::string& languages) {
+  base::string16 host = url_formatter::IDNToUnicode(gurl.host(), languages);
+  if (base::i18n::IsRTL())
+    base::i18n::WrapStringWithLTRFormatting(&host);

[Peter Kasting, 2015/12/02 01:14:40]

Is this really correct?  We force the host to LTR even when it contains RTL
chars?  I'm concerned that this may be wrong for e.g. an Arabic subdomain +
gTLD.

[felt, 2015/12/02 03:30:38]

This is the existing code, just moved. My understanding is that meacer@ tested
this. However, I have sent him an e-mail to ask him to check.

[meacer, 2015/12/02 18:20:23]

I carried this over from previous code too
(https://codereview.chromium.org/861953002/diff/40001/chrome/browser/ssl/capti...),
can't fully confirm it's correctness. I filed crbug.com/451213 back then to
investigate this exact thing. Maybe a good time to check that?

[Matt Giuca, 2015/12/02 23:59:42]

Thanks for looping me in. I need to go back and do some more research on the
master bug at some point. I think this is more or less the same as
crbug.com/351639, and the answer is, we don't really know how to display it at
this point.

The current code here seems *generally* acceptable in the interim (it is on the
way to my proposed solution, which is to always display URLs in LTR no matter
the context or contents). BUT it may not match the current Omnibox
implementation (which IIRC renders in RTL if the language is RTL). I think if
you want to match the Omnibox, you would delete these two lines of code. But I
haven't tested.

Is there a known website with RTL syntax with an SSL error. Perhaps we can add
it to badssl.com so we can test this case?

(I don't want to block this particular CL which is just a refactor. Let's
continue the discussion on http://crbug.com/451213.)

+  return host;
+}
+
+void PopulateSSLLayoutStrings(int cert_error,
+                              base::DictionaryValue* load_time_data) {
+  load_time_data->SetString("type", "SSL");
+  load_time_data->SetString("errorCode", net::ErrorToString(cert_error));
+  load_time_data->SetString(
+      "openDetails", l10n_util::GetStringUTF16(IDS_SSL_OPEN_DETAILS_BUTTON));
+  load_time_data->SetString(
+      "closeDetails", l10n_util::GetStringUTF16(IDS_SSL_CLOSE_DETAILS_BUTTON));
+}
+
+void PopulateSSLDebuggingStrings(const net::SSLInfo ssl_info,
+                                 const base::Time time_triggered,
+                                 base::DictionaryValue* load_time_data) {
+  load_time_data->SetString("subject",
+                            ssl_info.cert->subject().GetDisplayName());
+  load_time_data->SetString("issuer", ssl_info.cert->issuer().GetDisplayName());
+  load_time_data->SetString(
+      "expirationDate",
+      base::TimeFormatShortDate(ssl_info.cert->valid_expiry()));
+  load_time_data->SetString("currentDate",
+                            base::TimeFormatShortDate(time_triggered));
+  std::vector<std::string> encoded_chain;
+  ssl_info.cert->GetPEMEncodedChain(&encoded_chain);
+  load_time_data->SetString(
+      "pem", base::JoinString(encoded_chain, base::StringPiece()));
+}
+
+}  // namespace common_string_util
+
+}  // namespace security_interstitials