Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: build/android/gyp/generate_v14_resources.py

Issue 14812015: [Android] Auto-generate only necessary v14 resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comment update. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 #!/usr/bin/env python
2 #
3 # Copyright 2013 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file.
6
7 """Convert Android xml resources to API 14 compatible.
8
9 There are two reasons that we cannot just use API attributes,
10 so we are generating another set of resources by this script.
11
12 1. paddingStart attribute can cause a crash on Galaxy Tab 2.
13 2. There is a bug that paddingStart does not override paddingLeft on
14 JB-MR1. This is fixed on JB-MR2.
15
16 Therefore, this resource generation script can be removed when
17 we drop the support for JB-MR1.
18
19 Please refer to http://crbug.com/235118 for the details.
20 """
21
22 import optparse
23 import os
24 import re
25 import sys
26 import xml.dom.minidom as minidom
27
28 from util import build_utils
29
30
31 ATTRIBUTE_NAMESPACE = 'http://schemas.android.com/apk/res/android'
32
33 # Almost all the attributes that has "Start" or "End" in
34 # its name should be mapped.
35 ATTRIBUTES_TO_MAP = {'paddingStart' : 'paddingLeft',
36 'drawableStart' : 'drawableLeft',
37 'layout_alignStart' : 'layout_alignLeft',
38 'layout_marginStart' : 'layout_marginLeft',
39 'layout_alignParentStart' : 'layout_alignParentLeft',
40 'layout_toStartOf' : 'layout_toLeftOf',
41 'paddingEnd' : 'paddingRight',
42 'drawableEnd' : 'drawableRight',
43 'layout_alignEnd' : 'layout_alignRight',
44 'layout_marginEnd' : 'layout_marginRight',
45 'layout_alignParentEnd' : 'layout_alignParentRight',
46 'layout_toEndOf' : 'layout_toRightOf'}
47
48 ATTRIBUTES_TO_MAP_NS = {}
49
50 for k, v in ATTRIBUTES_TO_MAP.items():
51 ATTRIBUTES_TO_MAP_NS[(ATTRIBUTE_NAMESPACE, k)] = (ATTRIBUTE_NAMESPACE, v)
52
53 ATTRIBUTES_TO_MAP_NS_VALUES = set(ATTRIBUTES_TO_MAP_NS.values())
54
55
56 def IterateXmlElements(node):
57 """minidom helper function that iterates all the element nodes.
58 Iteration order is pre-order depth-first."""
59 if node.nodeType == node.ELEMENT_NODE:
60 yield node
61 for child_node in node.childNodes:
62 for child_node_element in IterateXmlElements(child_node):
63 yield child_node_element
64
65
66 def GenerateV14StyleResource(dom, output_file):
67 """Convert style resource to API 14 compatible style resource.
68
69 It's mostly a simple replacement, s/Start/Left s/End/Right,
70 on the attribute names specified by <item> element.
71 """
72 for style_element in dom.getElementsByTagName('style'):
73 for item_element in style_element.getElementsByTagName('item'):
74 namespace, name = item_element.attributes['name'].value.split(':')
75 # Note: namespace == 'android' is not precise because
76 # we are looking for 'http://schemas.android.com/apk/res/android' and
77 # 'android' can be aliased to another name in layout xml files where
78 # this style is used. e.g. xmlns:android="http://crbug.com/".
79 if namespace == 'android' and name in ATTRIBUTES_TO_MAP:
80 mapped_name = ATTRIBUTES_TO_MAP[name]
81 item_element.attributes['name'] = namespace + ':' + mapped_name
82
83 build_utils.MakeDirectory(os.path.dirname(output_file))
84 with open(output_file, 'w') as f:
85 dom.writexml(f, '', ' ', '\n', encoding='utf-8')
86
87
88 def GenerateV14LayoutResource(input_file, output_file):
89 """Convert layout resource to API 14 compatible layout resource.
90
91 It's mostly a simple replacement, s/Start/Left s/End/Right,
92 on the attribute names.
93 """
94 dom = minidom.parse(input_file)
95
96 for element in IterateXmlElements(dom):
97 all_names = element.attributes.keysNS()
98
99 # Iterate all the attributes to find attributes to convert.
100 # Note that name variable is actually a tuple that has namespace and name.
101 # For example,
102 # name == ('http://schemas.android.com/apk/res/android', 'paddingStart')
103 for name, value in list(element.attributes.itemsNS()):
104 # Note: gravity attributes are not necessary to convert because
105 # start/end values are backward-compatible. Explained at
106 # https://plus.sandbox.google.com/+RomanNurik/posts/huuJd8iVVXY?e=Showroom
107
108 # Convert any other API 17 Start/End attributes to Left/Right attributes.
109 # For example, from paddingStart="10dp" to paddingLeft="10dp"
110 if name in ATTRIBUTES_TO_MAP_NS:
111 mapped_name = ATTRIBUTES_TO_MAP_NS[name]
112
113 # Add the new mapped attribute and remove the original attribute.
114 # For example, add paddingLeft and remove paddingStart.
115 # Note that instead of element.setAttribute(...), this is more correct.
116 # element.setAttributeNS(mapped_name[0], mapped_name[1], value)
117 # However, there is a minidom bug that doesn't print namespace set by
118 # setAttributeNS. Hence this workaround.
119 # This is a similar bug discussion about minidom namespace normalizing.
120 # http://stackoverflow.com/questions/863774/how-to-generate-xml-document s-with-namespaces-in-python
121 element.setAttribute('android:' + mapped_name[1], value)
122 del element.attributes[name]
123 elif name in ATTRIBUTES_TO_MAP_NS_VALUES:
124 # TODO(kkimlabs): Enable warning once layouts have been converted
125 # print >> sys.stderror, 'Warning: layout should use xxx instead of yyy'
126 pass
127
128 build_utils.MakeDirectory(os.path.dirname(output_file))
129 with open(output_file, 'w') as f:
130 dom.writexml(f, '', ' ', '\n', encoding='utf-8')
131
132
133 def GenerateV14XmlResourcesInDir(input_dir, output_dir, only_styles=False):
134 """Convert resources to API 14 compatible XML resources in the directory."""
135 for input_file in build_utils.FindInDirectory(input_dir, '*.xml'):
136 output_file = os.path.join(output_dir,
137 os.path.relpath(input_file, input_dir))
138 if only_styles:
139 dom = minidom.parse(input_file)
140 if not dom.getElementsByTagName('style'):
141 continue
142 GenerateV14StyleResource(dom, output_file)
143 else:
144 GenerateV14LayoutResource(input_file, output_file)
145
146
147 def ParseArgs():
148 """Parses command line options.
149
150 Returns:
151 An options object as from optparse.OptionsParser.parse_args()
152 """
153 parser = optparse.OptionParser()
154 parser.add_option('--res-dir',
155 help='directory containing resources '
156 'used to generate v14 resources')
157 parser.add_option('--res-v14-dir',
158 help='output directory into which '
159 'v14 resources will be generated')
160 parser.add_option('--stamp', help='File to touch on success')
161
162 options, args = parser.parse_args()
163
164 if args:
165 parser.error('No positional arguments should be given.')
166
167 # Check that required options have been provided.
168 required_options = ('res_dir', 'res_v14_dir')
169 build_utils.CheckOptions(options, parser, required=required_options)
170 return options
171
172
173 def main(argv):
174 options = ParseArgs()
175
176 build_utils.DeleteDirectory(options.res_v14_dir)
177 build_utils.MakeDirectory(options.res_v14_dir)
178
179 for name in os.listdir(options.res_dir):
180 if not os.path.isdir(os.path.join(options.res_dir, name)):
181 continue
182
183 dir_pieces = name.split('-')
184 resource_type = dir_pieces[0]
185 qualifiers = dir_pieces[1:]
186
187 # Android pre-v17 API doesn't support RTL. Skip.
188 if 'ldrtl' in qualifiers:
189 continue
190
191 input_dir = os.path.join(options.res_dir, name)
192 output_dir = os.path.join(options.res_v14_dir, name)
193
194 # We only convert resources under layout*/, xml*/,
195 # and style resources under values*/.
196 # TODO(kkimlabs): don't process xml directly once all layouts have
197 # been moved out of XML directory. see http://crbug.com/238458
198 if resource_type in ('layout', 'xml'):
199 GenerateV14XmlResourcesInDir(input_dir, output_dir)
200 elif resource_type in ('values'):
201 GenerateV14XmlResourcesInDir(input_dir, output_dir, only_styles=True)
202
203 if options.stamp:
204 build_utils.Touch(options.stamp)
205
206 if __name__ == '__main__':
207 sys.exit(main(sys.argv))
208
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698