Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 14812014: MIPS: Fix NaN handling for start and end indexes in ArraySlice. (Closed)

Created:
7 years, 7 months ago by kilvadyb
Modified:
7 years, 6 months ago
Reviewers:
palfia, Toon Verwaest
CC:
danno, verwaest1, Paul Lind, kisg, palfia
Visibility:
Public.

Description

MIPS: Fix NaN handling for start and end indexes in ArraySlice. Casting NaN to int is unpredictable, on different architectures it produces different int value. TEST=test262/S15.4.4.10_A2.1_T2, test262/S15.4.4.10_A2.2_T2 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/builtins.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kilvadyb
7 years, 7 months ago (2013-05-10 09:46:29 UTC) #1
Toon Verwaest
lgtm
7 years, 7 months ago (2013-05-10 09:48:26 UTC) #2
palfia
7 years, 7 months ago (2013-05-10 13:06:50 UTC) #3
Landed as r14621.

Powered by Google App Engine
This is Rietveld 408576698