runtime/vm/constants_arm.h - Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constants_arm.h

Issue 14812005: Cleanup deoptimization code to make it architecture independent (in progress). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constants_arm.h

===================================================================

--- runtime/vm/constants_arm.h (revision 22382)

+++ runtime/vm/constants_arm.h (working copy)

@@ -182,11 +182,30 @@

const int kDartVolatileFpuRegCount = 8;

+// TODO(regis): Move these constants to stack_frame_arm.h.

// Dart stack frame layout.

-static const int kLastParamSlotIndex = 3;

-static const int kFirstLocalSlotIndex = -2;

+static const int kLastParamSlotIndex = 3; // From fp.

+static const int kFirstLocalSlotIndex = -2; // From fp.

+static const int kPcSlotIndexFromSp = -2;

+/* ARM Dart Frame Layout

+ | | <- TOS

+Callee frame | ... |

+ | current LR | (PC of current frame)

+ | PC Marker | (callee's frame code entry)

+ +-------------------+

+Current frame | ... | <- SP of current frame

+ | first local |

+ | caller's PP |

+ | caller's FP | <- FP of current frame

+ | caller's LR | (PC of caller frame)

+ | PC Marker | (current frame's code entry)

+ +-------------------+

+Caller frame | last parameter |

+ | ... |

+*/

// Values for the condition field as defined in section A3.2.

enum Condition {

kNoCondition = -1,

« no previous file with comments | « runtime/vm/code_patcher_x64.cc ('k') | runtime/vm/constants_ia32.h » ('j') | no next file with comments »