Cleanup deoptimization code to make it architecture independent (in progress).

runtime/vm/constants_x64.h

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_CONSTANTS_X64_H_
 #define VM_CONSTANTS_X64_H_
 
 namespace dart {
 
 enum Register {
@@ skipping 81 matching lines @@
 
 // Exception object is passed in this register to the catch handlers when an
 // exception is thrown.
 const Register kExceptionObjectReg = RAX;
 
 // Stack trace object is passed in this register to the catch handlers when
 // an exception is thrown.
 const Register kStackTraceObjectReg = RDX;
 
 
+// TODO(regis): Move these constants to stack_frame_x64.h.
 // Dart stack frame layout.
-static const int kLastParamSlotIndex = 2;
-static const int kFirstLocalSlotIndex = -2;
+static const int kLastParamSlotIndex = 2;  // From fp.
+static const int kFirstLocalSlotIndex = -2;  // From fp.
+static const int kPcSlotIndexFromSp = -1;

[srdjan, 2013/05/03 17:16:18]

Add an ASCII drawing explaining the constants.

[regis, 2013/05/03 18:34:12]

Done.

 
 
 enum ScaleFactor {
   TIMES_1 = 0,
   TIMES_2 = 1,
   TIMES_4 = 2,
   TIMES_8 = 3,
   TIMES_16 = 4,
   TIMES_HALF_WORD_SIZE = kWordSizeLog2 - 1
 };
@@ skipping 51 matching lines @@
 };
 
 
 // The largest multibyte nop we will emit.  This could go up to 15 if it
 // becomes important to us.
 const int MAX_NOP_SIZE = 8;
 
 }  // namespace dart
 
 #endif  // VM_CONSTANTS_X64_H_