components/precache/core/precache_fetcher_unittest.cc - Issue 1481143002: Added HttpUtils::HasValidators and HttpResponse::HasValidators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/precache/core/precache_fetcher_unittest.cc

Issue 1481143002: Added HttpUtils::HasValidators and HttpResponse::HasValidators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed first batch of bengr@'s comments Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/precache/core/precache_fetcher_unittest.cc

diff --git a/components/precache/core/precache_fetcher_unittest.cc b/components/precache/core/precache_fetcher_unittest.cc

index ceffb4d824985a6c58dbf2f31166fff931ead1d5..900a13b9b6a0a5ea7728f6b0d7d263309513be74 100644

--- a/components/precache/core/precache_fetcher_unittest.cc

+++ b/components/precache/core/precache_fetcher_unittest.cc

@@ -232,7 +232,7 @@ TEST_F(PrecacheFetcherFetcherTest, ResourceNotInCache) {

EXPECT_EQ(true, callback_called_);

}

-TEST_F(PrecacheFetcherFetcherTest, ResourceHasStrongValidators) {

+TEST_F(PrecacheFetcherFetcherTest, ResourceHasValidators) {

GURL url(kGoodResourceURL);

net::FakeURLFetcher *fetcher1 = nullptr, *fetcher2 = nullptr;

« no previous file with comments | « components/precache/core/precache_fetcher.cc ('k') | net/http/http_response_headers.h » ('j') | net/http/http_response_headers.h » ('J')