Added HttpUtils::HasValidators and HttpResponse::HasValidators

net/http/http_response_headers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // The rules for header parsing were borrowed from Firefox:
 // http://lxr.mozilla.org/seamonkey/source/netwerk/protocol/http/src/nsHttpResponseHead.cpp
 // The rules for parsing content-types were also borrowed from Firefox:
 // http://lxr.mozilla.org/mozilla/source/netwerk/base/src/nsURLHelper.cpp#834
 
 #include "net/http/http_response_headers.h"
@@ skipping 1230 matching lines @@
   std::string last_modified_header;
   EnumerateHeader(nullptr, "Last-Modified", &last_modified_header);
   std::string date_header;
   EnumerateHeader(nullptr, "Date", &date_header);
   return HttpUtil::HasStrongValidators(GetHttpVersion(),
                                        etag_header,
                                        last_modified_header,
                                        date_header);
 }
 
+bool HttpResponseHeaders::HasValidators() const {

[mmenke, 2016/02/25 07:56:45]

Erm...Wait...I'm not an expert on validators, but shouldn't strong validators be
a subset of validators, not the other way around?

[jamartin, 2016/02/25 11:30:49]

Yes it should and I believe it is so in this implementation.

A strong validator requires either a strong eTag or a LastModified older than 1
min. This function only checks for any eTag (weak or strong) or any LastModified
that can be parsed.

Am I missing something?

[mmenke, 2016/02/25 11:41:06]

Sorry, I was just confused by the fact this actually has no logic in it, and
relies on HttpUtil methods.

+  std::string etag_header;
+  EnumerateHeader(NULL, "etag", &etag_header);
+  std::string last_modified_header;
+  EnumerateHeader(NULL, "Last-Modified", &last_modified_header);
+  return HttpUtil::HasValidators(GetHttpVersion(), etag_header,
+                                 last_modified_header);
+}
+
 // From RFC 2616:
 // Content-Length = "Content-Length" ":" 1*DIGIT
 int64_t HttpResponseHeaders::GetContentLength() const {
   return GetInt64HeaderValue("content-length");
 }
 
 int64_t HttpResponseHeaders::GetInt64HeaderValue(
     const std::string& header) const {
   size_t iter = 0;
   std::string content_length_val;
@@ skipping 181 matching lines @@
   return true;
 }
 
 bool HttpResponseHeaders::IsChunkEncoded() const {
   // Ignore spurious chunked responses from HTTP/1.0 servers and proxies.
   return GetHttpVersion() >= HttpVersion(1, 1) &&
       HasHeaderValue("Transfer-Encoding", "chunked");
 }
 
 }  // namespace net