Added HttpUtils::HasValidators and HttpResponse::HasValidators

net/http/http_util_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/basictypes.h"
 #include "base/strings/string_util.h"
 #include "net/http/http_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 1160 matching lines @@
   std::string data = "name='value";
   HttpUtil::NameValuePairsIterator parser(data.begin(), data.end(), ';');
   EXPECT_TRUE(parser.valid());
 
   ASSERT_NO_FATAL_FAILURE(
       CheckNextNameValuePair(&parser, true, true, "name", "value"));
   ASSERT_NO_FATAL_FAILURE(CheckNextNameValuePair(
       &parser, false, true, std::string(), std::string()));
 }
 
+TEST(HttpUtilTest, HasValidators) {

[bengr, 2015/12/03 17:42:21]

For completeness, I think you should test the following cases for each of
http/0.9, http/1.0, and http/1.1:

no etag, no last-modified
weak etag, no last-modified
strong etag, no last-modified
no etag, last-modified
weak etag, last-modified
strong etag, last-modified
no etag, last-modified with bad date
weak etag, last-modified with bad date

For http 0.9 and 1.0, I'm ok with not testing strong and weak etags separately.
strong etag, last-modified with bad date

[jamartin (wrong), 2015/12/08 16:58:18]

Done.

I've gone for the full N^3 approach on this class but not in the other
(http_response_header_unittest.cc). Let me know if you want me to replicate
these tests in there as well.

+  EXPECT_FALSE(HttpUtil::HasValidators(HttpVersion(0, 9), "anything",
+                                       "Tue, 15 Nov 1994 12:45:26 GMT"));
+
+  EXPECT_FALSE(HttpUtil::HasValidators(HttpVersion(1, 0), "", ""));
+  EXPECT_FALSE(HttpUtil::HasValidators(HttpVersion(1, 0), "stub etag", ""));

[bengr, 2015/12/03 17:42:21]

Maybe use the string "anything" here too, as well as below.

[jamartin (wrong), 2015/12/08 16:58:18]

Done.

+  EXPECT_FALSE(HttpUtil::HasValidators(HttpVersion(1, 0), "", "invalid date"));
+  EXPECT_TRUE(HttpUtil::HasValidators(HttpVersion(1, 0), "",

[bengr, 2015/12/03 17:42:21]

Also EXPECT_TRUE when both an etag and a last-modified are supplied.

[jamartin (wrong), 2015/12/08 16:58:18]

Done.

+                                      "Tue, 15 Nov 1994 12:45:26 GMT"));
+
+  EXPECT_FALSE(HttpUtil::HasValidators(HttpVersion(1, 1), "", ""));
+  EXPECT_TRUE(HttpUtil::HasValidators(HttpVersion(1, 1), "stub etag", ""));
+  EXPECT_TRUE(HttpUtil::HasValidators(HttpVersion(1, 1), "stub etag",
+                                      "Tue, 15 Nov 1994 12:45:26 GMT"));
+}
+
 }  // namespace net