Media: AudioVideoMetadataParser - Parse rotation metadata.

media/base/audio_video_metadata_extractor_unittest.cc

Index: media/base/audio_video_metadata_extractor_unittest.cc
diff --git a/media/base/audio_video_metadata_extractor_unittest.cc b/media/base/audio_video_metadata_extractor_unittest.cc
index c55cd5df3b2c1bcee4da9748c188e66dde1ab317..31369436a4d6167e7785206c42f35be85ea04fb3 100644
--- a/media/base/audio_video_metadata_extractor_unittest.cc
+++ b/media/base/audio_video_metadata_extractor_unittest.cc
@@ -27,7 +27,7 @@ scoped_ptr<AudioVideoMetadataExtractor> GetExtractor(
   EXPECT_EQ(expected_result, extracted);
 
   if (!extracted)
-    return extractor.Pass();
+    return scoped_ptr<AudioVideoMetadataExtractor>();

[Lei Zhang, 2014/02/14 02:35:51]

Isn't this going to case a crash when the caller calls extractor->foo() ?

[tommycli, 2014/02/14 17:06:48]

Done.

 
   EXPECT_EQ(expected_duration, extractor->duration());
 
@@ -61,6 +61,13 @@ TEST(AudioVideoMetadataExtractorTest, VideoWebM) {
 }
 
 #if defined(USE_PROPRIETARY_CODECS)
+TEST(AudioVideoMetadataExtractorTest, AndroidRotatedMP4Video) {
+  scoped_ptr<AudioVideoMetadataExtractor> extractor =
+      GetExtractor("90rotation.mp4", true, 0, 1920, 1080);
+
+  EXPECT_EQ(90, extractor->rotation());
+}
+
 TEST(AudioVideoMetadataExtractorTest, AudioMP3) {
   scoped_ptr<AudioVideoMetadataExtractor> extractor =
       GetExtractor("id3_png_test.mp3", true, 1, -1, -1);