chrome/browser/ui/cocoa/status_bubble_mac.mm - Issue 148113011: Fix the Mac status bubble.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/status_bubble_mac.mm

Issue 148113011: Fix the Mac status bubble. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: try upload again Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/status_bubble_mac.mm

diff --git a/chrome/browser/ui/cocoa/status_bubble_mac.mm b/chrome/browser/ui/cocoa/status_bubble_mac.mm

index 62507bfe09d1b7da61d7d186f8be393133fd3166..f4bc566eda9899e9b89932d2688a8ff5b5d41163 100644

--- a/chrome/browser/ui/cocoa/status_bubble_mac.mm

+++ b/chrome/browser/ui/cocoa/status_bubble_mac.mm

@@ -398,8 +398,8 @@ void StatusBubbleMac::Create() {

[[StatusBubbleAnimationDelegate alloc] initWithStatusBubble:this];

[animation_delegate autorelease];

[animation setDelegate:animation_delegate];

- base::scoped_nsobject<NSMutableDictionary> animation_dictionary(

- [[window_ animations] mutableCopy]);

+ NSMutableDictionary* animation_dictionary =

+ [NSMutableDictionary dictionaryWithDictionary:[window_ animations]];

[animation_dictionary.get() setObject:animation forKey:kFadeAnimationKey];

Mark Mentovai 2014/02/12 21:14:32 No .get() now. Same on the next line.

Avi (use Gerrit) 2014/02/12 22:23:30 Done.

[window_ setAnimations:animation_dictionary.get()];

« no previous file with comments | « no previous file | no next file » | no next file with comments »