Fix the Mac status bubble.

Fix the Mac status bubble.

This partially reverts the "cleanup" of r250260. The "cleaner" version is not equivalent if the call to -[NSWindow animations] returns nil.

BUG=none
TEST=no change

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251082

[Mark Mentovai, 2014-02-12 21:10:18]

LGTM

[Avi (use Gerrit), 2014-02-12 21:11:29]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-02-12 21:13:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/148113011/40001

[Mark Mentovai, 2014-02-12 21:14:32]

https://codereview.chromium.org/148113011/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/status_bubble_mac.mm (right):

https://codereview.chromium.org/148113011/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/status_bubble_mac.mm:403: [animation_dictionary.get()
setObject:animation forKey:kFadeAnimationKey];
No .get() now. Same on the next line.

[commit-bot: I haz the power, 2014-02-12 22:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:08:28]

Retried try job too often on linux_rel for step(s) check_deps
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Avi (use Gerrit), 2014-02-12 22:17:33]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-02-12 22:19:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/148113011/40001

[Avi (use Gerrit), 2014-02-12 22:23:13]

The CQ bit was checked by avi@chromium.org

[Avi (use Gerrit), 2014-02-12 22:23:30]

yeah

https://codereview.chromium.org/148113011/diff/40001/chrome/browser/ui/cocoa/...
File chrome/browser/ui/cocoa/status_bubble_mac.mm (right):

https://codereview.chromium.org/148113011/diff/40001/chrome/browser/ui/cocoa/...
chrome/browser/ui/cocoa/status_bubble_mac.mm:403: [animation_dictionary.get()
setObject:animation forKey:kFadeAnimationKey];
On 2014/02/12 21:14:32, Mark Mentovai wrote:
> No .get() now. Same on the next line.

Done.

[commit-bot: I haz the power, 2014-02-12 22:24:19]

Failed to trigger a try job on mac_rel
HTTP Error 400: Bad Request

[commit-bot: I haz the power, 2014-02-12 22:24:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/148113011/360001

[commit-bot: I haz the power, 2014-02-13 00:23:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:23:22]

Retried try job too often on win_rel for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Avi (use Gerrit), 2014-02-13 15:49:44]

The CQ bit was checked by avi@chromium.org

[commit-bot: I haz the power, 2014-02-13 15:50:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/avi@chromium.org/148113011/360001

[commit-bot: I haz the power, 2014-02-13 18:13:11]

Change committed as 251082