Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 148113010: Fix android build issues with atomics (Closed)

Created:
6 years, 10 months ago by Chris Dalton
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Fix android build issues with atomics Uses inline methods for sk_atomic_inc/add/dec instead of #define. Since those methods are declared as static in SkThread.h, they need a definition or else the compiler generates an error. Also corrects a typo. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13360

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M src/ports/SkAtomics_android.h View 2 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Chris Dalton
6 years, 10 months ago (2014-01-31 21:54:52 UTC) #1
bsalomon
Changing reviewers to Derek and Ben.
6 years, 10 months ago (2014-01-31 21:57:11 UTC) #2
bungeman-skia
This LGTM, and I like having the static inlines instead of the preprocessor defines anyway. ...
6 years, 10 months ago (2014-02-03 15:42:15 UTC) #3
djsollen
lgtm
6 years, 10 months ago (2014-02-03 16:38:08 UTC) #4
Chris Dalton
On 2014/02/03 16:38:08, djsollen wrote: > lgtm Hey guys, has this landed?
6 years, 10 months ago (2014-02-07 02:30:06 UTC) #5
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 10 months ago (2014-02-07 13:42:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cdalton@nvidia.com/148113010/1
6 years, 10 months ago (2014-02-07 13:42:06 UTC) #7
bsalomon
On 2014/02/07 02:30:06, Chris Dalton wrote: > On 2014/02/03 16:38:08, djsollen wrote: > > lgtm ...
6 years, 10 months ago (2014-02-07 13:42:38 UTC) #8
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 13:55:59 UTC) #9
Message was sent while issue was closed.
Change committed as 13360

Powered by Google App Engine
This is Rietveld 408576698