chromeos: Avoid notification for original Spring charger.

chromeos: Avoid notification for original Spring charger.

Fix a bug that resulted in "Battery full" notifications
being shown when using an original Spring charger.

BUG=338376
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247397

[Daniel Erat, 2014-01-27 17:36:25]

https://codereview.chromium.org/148113004/diff/1/ash/system/chromeos/power/tr...
File ash/system/chromeos/power/tray_power.cc (right):

https://codereview.chromium.org/148113004/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:254:
PowerStatus::Get()->IsBatteryFull()) {
These IsBatteryFull() checks aren't necessary for the fix, but I'm leaning
slightly towards including them just to reduce the chances of something like
this happening again in the future.

[jennyz, 2014-01-27 18:03:37]

https://codereview.chromium.org/148113004/diff/1/ash/system/chromeos/power/tr...
File ash/system/chromeos/power/tray_power.cc (right):

https://codereview.chromium.org/148113004/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:237:
status.IsOriginalSpringChargerConnected()) {
what if the user confirms they are using the safe spring charger, although it
has the same id as the original spring charger(bad one)?

https://codereview.chromium.org/148113004/diff/1/ash/system/chromeos/power/tr...
ash/system/chromeos/power/tray_power.cc:254:
PowerStatus::Get()->IsBatteryFull()) {
On 2014/01/27 17:36:26, Daniel Erat wrote:
> These IsBatteryFull() checks aren't necessary for the fix, but I'm leaning
> slightly towards including them just to reduce the chances of something like
> this happening again in the future.

agree.

[jennyz, 2014-01-27 18:08:10]

LGTM. woops, I forgot we report for the new spring charger as Main charger.
Sorry, this one is good then.

[commit-bot: I haz the power, 2014-01-27 18:09:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/148113004/1

[commit-bot: I haz the power, 2014-01-28 00:16:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/148113004/1

[commit-bot: I haz the power, 2014-01-28 02:53:19]

Change committed as 247397