Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/android/forwarder2/host_controller.h

Issue 148113003: forwarder2: Make the Forwarder instances operate on a single thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address David's comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/android/forwarder2/forwarders_manager.cc ('k') | tools/android/forwarder2/pipe_notifier.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/android/forwarder2/host_controller.h
diff --git a/tools/android/forwarder2/host_controller.h b/tools/android/forwarder2/host_controller.h
index fbf3847a7e1c4ab96c4f762918c42c3aa354d258..d228bcce00dd662f198e6b4dbeb276d35dc6e5c4 100644
--- a/tools/android/forwarder2/host_controller.h
+++ b/tools/android/forwarder2/host_controller.h
@@ -85,14 +85,6 @@ class HostController {
// Task runner used for deletion set at deletion time (i.e. the object is
// deleted on the same thread it is created on).
const scoped_refptr<base::SingleThreadTaskRunner> deletion_task_runner_;
- // Note that this thread must outlive |forwarders_manager_| below. The
- // ForwardersManager's internal delegate (outliving ForwardersManager) may
- // post a task to this thread when it gets deleted. Also note that
- // base::Thread joins on destruction which means that ~Thread() will only
- // return after it executed all the tasks enqueued in its message loop. This
- // also means that it is guaranteed that all the Forwarder instances owned by
- // the ForwardersManager's internal delegate are destructed before
- // ~HostController() returns.
base::Thread thread_;
ForwardersManager forwarders_manager_;
« no previous file with comments | « tools/android/forwarder2/forwarders_manager.cc ('k') | tools/android/forwarder2/pipe_notifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698