Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/api.cc

Issue 1481103002: [proxies] Implement [[Set]]. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/contexts.h » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index cb8d0ff946aec93a7ec4ebff5d54e767ee7e5cc7..d8bf9230031c8ea35d26906b193a9bb5ea4ebcbf 100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3508,7 +3508,8 @@ Maybe<bool> v8::Object::CreateDataProperty(v8::Local<v8::Context> context,
i::LookupIterator it = i::LookupIterator::PropertyOrElement(
isolate, self, key_obj, i::LookupIterator::OWN);
- Maybe<bool> result = i::JSReceiver::CreateDataProperty(&it, value_obj);
+ Maybe<bool> result =
+ i::JSReceiver::CreateDataProperty(&it, value_obj, i::Object::DONT_THROW);
has_pending_exception = result.IsNothing();
RETURN_ON_FAILED_EXECUTION_PRIMITIVE(bool);
return result;
@@ -3524,7 +3525,8 @@ Maybe<bool> v8::Object::CreateDataProperty(v8::Local<v8::Context> context,
i::Handle<i::Object> value_obj = Utils::OpenHandle(*value);
i::LookupIterator it(isolate, self, index, i::LookupIterator::OWN);
- Maybe<bool> result = i::JSReceiver::CreateDataProperty(&it, value_obj);
+ Maybe<bool> result =
+ i::JSReceiver::CreateDataProperty(&it, value_obj, i::Object::DONT_THROW);
has_pending_exception = result.IsNothing();
RETURN_ON_FAILED_EXECUTION_PRIMITIVE(bool);
return result;
« no previous file with comments | « no previous file | src/contexts.h » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698