Chromium Code Reviews

Issue 1481093003: MIPS64: [turbofan] Implemented the TruncateFloat32ToUint64 TurboFan operator. (Closed)

Created:
5 years ago by akos.palfi.imgtec
Modified:
5 years ago
Reviewers:
balazs.kilvady, paul.l..., ahaas, Alan Li
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: [turbofan] Implemented the TruncateFloat32ToUint64 TurboFan operator. Port 68cc0be2ad75c698d08d6672b69ad9649418cd9f Original commit message: The TruncateFloat32ToUint64 operator converts a float32 to an uint64 using round-to-zero rounding mode. If the input value is outside uint64 range, then the result depends on the architecture. I provide an implementation for x64 and arm64. BUG= Committed: https://crrev.com/baae7a0333bd0f8d36049ccc6c8ea66920a68bcc Cr-Commit-Position: refs/heads/master@{#32383}

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+51 lines, -2 lines)
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +6 lines, -0 lines 0 comments
M src/compiler/mips64/instruction-codes-mips64.h View 1 chunk +1 line, -0 lines 0 comments
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +1 line, -1 line 0 comments
M src/mips64/macro-assembler-mips64.h View 1 chunk +4 lines, -0 lines 0 comments
M src/mips64/macro-assembler-mips64.cc View 3 chunks +39 lines, -1 line 0 comments

Messages

Total messages: 8 (3 generated)
akos.palfi.imgtec
PTAL.
5 years ago (2015-11-27 23:20:20 UTC) #2
paul.l...
LGTM (rs). Thanks!
5 years ago (2015-11-28 02:05:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481093003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481093003/1
5 years ago (2015-11-28 02:07:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-28 02:27:05 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-28 02:27:25 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/baae7a0333bd0f8d36049ccc6c8ea66920a68bcc
Cr-Commit-Position: refs/heads/master@{#32383}

Powered by Google App Engine