Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1481033002: jni: Allow nullptr to be converted to JavaParamRef. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
Yaron
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

jni: Allow nullptr to be converted to JavaParamRef. Some unit tests call JNI methods from C++ and want to be able to pass null as a parameter. Allow nullptr_t to be converted to JavaParamRef to keep this working. BUG=506850 R=yfriedman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/0b2cd651ddd37de8a4072efd022681faeb5394de

Patch Set 1 #

Patch Set 2 : add std:: prefix to make clang happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M base/android/scoped_java_ref.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Torne
5 years ago (2015-11-27 11:19:12 UTC) #2
Yaron
lgtm
5 years ago (2015-11-27 14:55:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481033002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481033002/1
5 years ago (2015-11-27 16:20:18 UTC) #5
Torne
Oops, forgot std:: prefix and apparently gcc doesn't care (which is wrong) but clang does. ...
5 years ago (2015-11-27 17:23:23 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0b2cd651ddd37de8a4072efd022681faeb5394de Cr-Commit-Position: refs/heads/master@{#362026}
5 years ago (2015-11-27 18:14:12 UTC) #8
Torne
5 years ago (2015-11-27 18:14:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0b2cd651ddd37de8a4072efd022681faeb5394de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698