Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issue 1481023002: MIPS: Fixup disasembler for ctc1 and cfc1 (Closed)

Created:
5 years ago by Djordje.Pesic
Modified:
5 years ago
Reviewers:
Djordje.Pesic, balazs.kilvady, ilija.pavlovic, akos.palfi.imgtec
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Fixup disasembler for ctc1 and cfc1 These instructions now show FCSR in disassembly, instead f31 BUG= Committed: https://crrev.com/b287c74308fdb1e2a9e657ff454509fdc562250e Cr-Commit-Position: refs/heads/master@{#32366}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -32 lines) Patch
M src/mips/disasm-mips.cc View 3 chunks +48 lines, -16 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 3 chunks +48 lines, -16 lines 0 comments Download
M test/cctest/test-disasm-mips.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M test/cctest/test-disasm-mips64.cc View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
balazs.kilvady
lgtm
5 years ago (2015-11-27 10:57:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1481023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1481023002/1
5 years ago (2015-11-27 10:58:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-27 11:38:07 UTC) #7
commit-bot: I haz the power
5 years ago (2015-11-27 11:38:26 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b287c74308fdb1e2a9e657ff454509fdc562250e
Cr-Commit-Position: refs/heads/master@{#32366}

Powered by Google App Engine
This is Rietveld 408576698