Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 148093016: [Telemetry] Clean up some page cycler cruft now that idb has moved out. (Closed)

Created:
6 years, 10 months ago by tonyg
Modified:
6 years, 10 months ago
Reviewers:
cmumford
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Telemetry] Clean up some page cycler cruft now that idb has moved out. The Indexed DB page cycler has been replaced by a real benchmark. So we no longer need the age-old hacks to do idb testing via a page cycler. BUG=196406 TBR=cmumford@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251979

Patch Set 1 #

Patch Set 2 : reupload #

Total comments: 1

Patch Set 3 : Remove database page cycler too #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -576 lines) Patch
D tools/page_cycler/database/common.js View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
D tools/page_cycler/database/delete-transactions/index.html View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D tools/page_cycler/database/delete-transactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/head.js View 1 2 1 chunk +0 lines, -125 lines 0 comments Download
D tools/page_cycler/database/insert-transactions/index.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D tools/page_cycler/database/insert-transactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/pseudo-random-transactions/index.html View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D tools/page_cycler/database/pseudo-random-transactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/select-readtransactions-read-results/index.html View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D tools/page_cycler/database/select-readtransactions-read-results/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/select-readtransactions/index.html View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D tools/page_cycler/database/select-readtransactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/select-transactions/index.html View 1 2 1 chunk +0 lines, -25 lines 0 comments Download
D tools/page_cycler/database/select-transactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D tools/page_cycler/database/update-transactions/index.html View 1 2 1 chunk +0 lines, -28 lines 0 comments Download
D tools/page_cycler/database/update-transactions/start.html View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
M tools/perf/measurements/page_cycler.js View 2 chunks +3 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tonyg
6 years, 10 months ago (2014-02-05 16:17:08 UTC) #1
cmumford
You can probably use this bug: 196406 I'm not yet a committer. Am I allowed ...
6 years, 10 months ago (2014-02-05 16:28:49 UTC) #2
tonyg
On 2014/02/05 16:28:49, cmumford wrote: > You can probably use this bug: 196406 Done. > ...
6 years, 10 months ago (2014-02-19 01:55:38 UTC) #3
tonyg
The CQ bit was checked by tonyg@chromium.org
6 years, 10 months ago (2014-02-19 01:55:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/148093016/70001
6 years, 10 months ago (2014-02-19 01:58:01 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 06:46:08 UTC) #6
Message was sent while issue was closed.
Change committed as 251979

Powered by Google App Engine
This is Rietveld 408576698