Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Unified Diff: compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py

Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py
diff --git a/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py b/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py
index b903420a02430cae8031b7c0083d8306755db022..5ca6b411f42b59a671d6d10bb4402a14ffd67a12 100644
--- a/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py
+++ b/compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary_test.py
@@ -23,6 +23,7 @@ class TestWriteJsonSummary(unittest.TestCase):
self._gm_json_path = os.path.join(self._test_json_dir, 'gm_json_mock.py')
self._imagediffdb_path = os.path.join(self._test_json_dir,
'imagediffdb_mock.py')
+ self._skpdiff_output_csv = os.path.join(self._test_json_dir, 'output.csv')
self._actual_output_dir = tempfile.mkdtemp()
self._actual_output_file_path = os.path.join(self._actual_output_dir,
self._output_file_name)
@@ -48,7 +49,8 @@ class TestWriteJsonSummary(unittest.TestCase):
gs_skp_dir=self._gs_skp_dir,
slave_num=self._slave_num,
gm_json_path=self._gm_json_path,
- imagediffdb_path=self._imagediffdb_path)
+ imagediffdb_path=self._imagediffdb_path,
+ skpdiff_output_csv=self._skpdiff_output_csv)
self.assertTrue(
filecmp.cmp(os.path.join(self._test_json_dir, self._output_file_name),
@@ -66,7 +68,8 @@ class TestWriteJsonSummary(unittest.TestCase):
gs_skp_dir=self._gs_skp_dir,
slave_num=self._slave_num,
gm_json_path=self._gm_json_path,
- imagediffdb_path=self._imagediffdb_path)
+ imagediffdb_path=self._imagediffdb_path,
+ skpdiff_output_csv=self._skpdiff_output_csv)
self.assertFalse(os.path.isfile(self._actual_output_file_path))

Powered by Google App Engine
This is Rietveld 408576698