Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh

Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh
diff --git a/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh b/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh
index 01cbd5d28d51d035fbc21a9116bc6207cfbb49ec..f54df98d20fd1d00045fb6bdec5781a6a61be015 100644
--- a/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh
+++ b/compute_engine_scripts/telemetry/telemetry_slave_scripts/vm_run_skia_try.sh
@@ -198,6 +198,13 @@ OUTPUT_DIR_NOPATCH=${IMG_ROOT}${OUTPUT_DIR_NOPATCH_DIR_NAME}
mkdir -p $OUTPUT_DIR_NOPATCH
run_render_pictures $OUTPUT_DIR_NOPATCH $MESA_NOPATCH_RUN
+echo "== Run skpdiff to get the CSV with perceptual similarity metrics =="
+SKPDIFF_OUTPUT_FILE=/tmp/skpdiff-$RUN_ID.csv
+./out/Release/skpdiff \
+ -f $OUTPUT_DIR_NOPATCH $OUTPUT_DIR_WITHPATCH \
+ --csv $SKPDIFF_OUTPUT_FILE \
+ -d perceptual
+
echo "== Comparing pictures and saving differences in JSON output file =="
cd /home/default/skia-repo/buildbot/compute_engine_scripts/telemetry/telemetry_slave_scripts
JSON_SUMMARY_DIR=/tmp/summary-$RUN_ID
@@ -213,7 +220,8 @@ python write_json_summary.py \
--gs_skp_dir=$GS_SKP_DIR \
--slave_num=$SLAVE_NUM \
--gm_json_path=/home/default/skia-repo/trunk/gm/gm_json.py \
- --imagediffdb_path=/home/default/skia-repo/trunk/gm/rebaseline_server/imagediffdb.py
+ --imagediffdb_path=/home/default/skia-repo/trunk/gm/rebaseline_server/imagediffdb.py \
+ --skpdiff_output_csv=$SKPDIFF_OUTPUT_FILE
echo "== Copy everything to Google Storage =="
# Get list of failed file names and upload only those to Google Storage.

Powered by Google App Engine
This is Rietveld 408576698