compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py - Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output

Unified Diff: compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py

Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Rebase Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner.py ('K') | « compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner.py ('k') | compute_engine_scripts/telemetry/telemetry_master_scripts/test_data/combiner/differences/summary1.json » ('j') | compute_engine_scripts/telemetry/telemetry_slave_scripts/write_json_summary.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py

diff --git a/compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py b/compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py

index 8ab0533a557433f210bc381d23fdafb151dbd378..0bab6fd40cd8a5de6d476a4dff726424652e81b1 100644

--- a/compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py

+++ b/compute_engine_scripts/telemetry/telemetry_master_scripts/json_summary_combiner_test.py

@@ -77,12 +77,12 @@ class TestJsonSummaryCombiner(unittest.TestCase):

'fileslave1_1.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave1/'

'fileslave1_.skp',

- 111, 112, 113, 114),

+ 111, 112, 113, 114, 115),

json_summary_combiner.FileInfo(

'fileslave1_2.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave1/'

'fileslave1_.skp',

- 121, 122, 123, 124)],

+ 121, 122, 123, 124, 125)],

skps_location='gs://dummy-bucket/skps/slave1',

files_location_diffs='gs://dummy-bucket/slave1/diffs',

files_location_whitediffs='gs://dummy-bucket/slave1/whitediffs',

@@ -95,7 +95,7 @@ class TestJsonSummaryCombiner(unittest.TestCase):

'fileslave2_1.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave2/'

'fileslave2_.skp',

- 211, 212, 213, 214)],

+ 211, 212, 213, 214, 215)],

skps_location='gs://dummy-bucket/skps/slave2',

files_location_diffs='gs://dummy-bucket/slave2/diffs',

files_location_whitediffs='gs://dummy-bucket/slave2/whitediffs',

@@ -108,22 +108,22 @@ class TestJsonSummaryCombiner(unittest.TestCase):

'fileslave3_1.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave3/'

'fileslave3_.skp',

- 311, 312, 313, 314),

+ 311, 312, 313, 314, 315),

json_summary_combiner.FileInfo(

'fileslave3_2.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave3/'

'fileslave3_.skp',

- 321, 322, 323, 324),

+ 321, 322, 323, 324, 325),

json_summary_combiner.FileInfo(

'fileslave3_3.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave3/'

'fileslave3_.skp',

- 331, 332, 333, 334),

+ 331, 332, 333, 334, 335),

json_summary_combiner.FileInfo(

'fileslave3_4.png',

'http://storage.cloud.google.com/dummy-bucket/skps/slave3/'

'fileslave3_.skp',

- 341, 342, 343, 344)],

+ 341, 342, 343, 344, 345)],

skps_location='gs://dummy-bucket/skps/slave3',

files_location_diffs='gs://dummy-bucket/slave3/diffs',

files_location_whitediffs='gs://dummy-bucket/slave3/whitediffs',