compute_engine_scripts/telemetry/json_summary_constants.py - Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: compute_engine_scripts/telemetry/json_summary_constants.py

Issue 148093012: Add magnifying ability, perceptual diff and improve layout of Skia Tryserver HTML output (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | compute_engine_scripts/telemetry/static-files/README » ('j') | compute_engine_scripts/telemetry/static-files/angular.min.js » ('J')

OLD	NEW
1 #!/usr/bin/env python	1 #!/usr/bin/env python
	epoger 2014/02/03 21:17:13 Where can I go to see this in action? I tried to Where can I go to see this in action? I tried to view the most recent Chromium Try and Skia Try tasks at https://skia-tree-status.appspot.com/skia-telemetry/all_tasks#telemetry : https://storage.cloud.google.com/chromium-skia-gm/telemetry/tryserver-outputs... https://storage.cloud.google.com/chromium-skia-gm/telemetry/skia-tryserver/ht... But in both cases, the page failed to load with "This webpage has a redirect loop" (They both redirected me to URLs starting with https://www.google.com/accounts/ServiceLogin?service=cds&passive=1209600&cont... , even though I already authenticated myself)
2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2013 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 """Module that contains constants for the master/slave JSON summary scripts."""	6 """Module that contains constants for the master/slave JSON summary scripts."""

7	7

8	8

9 JSONKEY_FAILED_FILES = 'failedFiles'	9 JSONKEY_FAILED_FILES = 'failedFiles'

10 JSONKEY_SKPS_LOCATION = 'skpsLocation'	10 JSONKEY_SKPS_LOCATION = 'skpsLocation'

11 JSONKEY_FILES_LOCATION_NOPATCH = 'filesLocationNopatch'	11 JSONKEY_FILES_LOCATION_NOPATCH = 'filesLocationNopatch'

12 JSONKEY_FILES_LOCATION_WITHPATCH = 'filesLocationWithpatch'	12 JSONKEY_FILES_LOCATION_WITHPATCH = 'filesLocationWithpatch'

13 JSONKEY_FILES_LOCATION_DIFFS = 'filesLocationDiffs'	13 JSONKEY_FILES_LOCATION_DIFFS = 'filesLocationDiffs'

14 JSONKEY_FILES_LOCATION_WHITE_DIFFS = 'filesLocationWhiteDiffs'	14 JSONKEY_FILES_LOCATION_WHITE_DIFFS = 'filesLocationWhiteDiffs'

15 JSONKEY_FAILED_FILES_COUNT = 'failedFilesCount'	15 JSONKEY_FAILED_FILES_COUNT = 'failedFilesCount'

16 JSONKEY_FILE_NAME = 'fileName'	16 JSONKEY_FILE_NAME = 'fileName'

17 JSONKEY_SKP_LOCATION = 'skpLocation'	17 JSONKEY_SKP_LOCATION = 'skpLocation'

18 JSONKEY_NUM_PIXELS_DIFFERING = 'numPixelsDiffering'	18 JSONKEY_NUM_PIXELS_DIFFERING = 'numPixelsDiffering'

19 JSONKEY_PERCENT_PIXELS_DIFFERING = 'percentPixelsDiffering'	19 JSONKEY_PERCENT_PIXELS_DIFFERING = 'percentPixelsDiffering'

20 JSONKEY_WEIGHTED_DIFF_MEASURE = 'weightedDiffMeasure'	20 JSONKEY_WEIGHTED_DIFF_MEASURE = 'weightedDiffMeasure'

21 JSONKEY_MAX_DIFF_PER_CHANNEL = 'maxDiffPerChannel'	21 JSONKEY_MAX_DIFF_PER_CHANNEL = 'maxDiffPerChannel'

	22 JSONKEY_PERCEPTUAL_SIMILARITY = 'perceptualSimilarity'
	epoger 2014/02/03 21:17:13 I think it may confuse users for some of these met I think it may confuse users for some of these metrics to measure similarity, and others to measure difference. We'll see.
OLD	NEW