Issue 148093009: Extend ArrayPop hydrogen support to COW arrays and popping from empty arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148093009: Extend ArrayPop hydrogen support to COW arrays and popping from empty arrays. (Closed)

Created:
6 years, 10 months ago by Toon Verwaest

Modified:
6 years, 10 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Extend ArrayPop hydrogen support to COW arrays and popping from empty arrays. R=mvstanton@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18901

Patch Set 4 : Remove the extra boundscheck #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -13 lines)			Patch
	M	src/hydrogen.cc	View	1 2 3	2 chunks	+26 lines, -13 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Toon, one question below... --Michael https://codereview.chromium.org/148093009/diff/20001/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/148093009/diff/20001/src/hydrogen.cc#newcode7675 src/hydrogen.cc:7675: reduced_length); I just ...

6 years, 10 months ago (2014-01-29 10:16:09 UTC) #2

Toon Verwaest

6 years, 10 months ago (2014-01-29 12:53:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r18901 (presubmit successful).

Expand Messages | Collapse Messages

Issue 148093009: Extend ArrayPop hydrogen support to COW arrays and popping from empty arrays. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Remove the extra boundscheck #

Messages