xkb:us::eng is now always in list of available input methods at OOBE.

xkb:us::eng is now always in list of available input methods at OOBE.

It seems reasonable to have US qwerty as a last resort option for the keyboard
selection at OOBE.

So, basically add US qwerty as the last item of the keyboard selection drop
down if it's not already surfaced through other means (e.g. VPD or preferred
list based on the currently selected locale).

Note: to test this modification, you need hardware layout set to
non "xkb:us::eng", but to some other latin layout. Because hardware
latin layout is always first in the list of available layouts at OOBE.

BUG=327195
TEST=manual

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247991

[Alexander Alekseev, 2014-01-27 14:12:01]

Please review.

[Nikita (slow), 2014-01-27 15:22:09]

I see that you've added US keyboard layout as an additional one to the list of
keyboard layouts on out-of-box welcome screen.

But I think this integration needs to be done deeper. If user has proceed with
oobe US keyboard layout should be added to the list of the activated layouts.

https://codereview.chromium.org/148093003/diff/1/chrome/browser/ui/webui/chro...
File chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc (right):

https://codereview.chromium.org/148093003/diff/1/chrome/browser/ui/webui/chro...
chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc:278: static
const std::string kUSlayout("xkb:us::eng");  // Global default
nit: Please extract constant.

[Nikita (slow), 2014-01-29 15:07:35]

lgtm with that nit after offline discussion

[Alexander Alekseev, 2014-01-29 16:05:31]

Done.

[commit-bot: I haz the power, 2014-01-29 16:05:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alemate@chromium.org/148093003/50001

[commit-bot: I haz the power, 2014-01-29 21:44:17]

Retried try job too often on linux_chromeos_clang for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2014-01-30 12:49:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alemate@chromium.org/148093003/70001

[commit-bot: I haz the power, 2014-01-30 15:05:55]

Retried try job too often on win_rel for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-30 15:53:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alemate@chromium.org/148093003/70001

[commit-bot: I haz the power, 2014-01-30 18:01:22]

Change committed as 247991

[commit-bot: I haz the power, 2014-01-30 18:01:22]

CQ bit was unchecked on CL. Ignoring.