Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Unified Diff: src/transitions.cc

Issue 1480873003: Introduce instance type for transition arrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/transitions.cc
diff --git a/src/transitions.cc b/src/transitions.cc
index 0d1b7d65c02c2d3af29f0d1093d276616c150f69..9b52d849b4341e156c5111b6bf9a7e4cb1dfbedb 100644
--- a/src/transitions.cc
+++ b/src/transitions.cc
@@ -391,7 +391,7 @@ int TransitionArray::Capacity(Object* raw_transitions) {
Handle<TransitionArray> TransitionArray::Allocate(Isolate* isolate,
int number_of_transitions,
int slack) {
- Handle<FixedArray> array = isolate->factory()->NewFixedArray(
+ Handle<FixedArray> array = isolate->factory()->NewTransitionArray(
LengthFor(number_of_transitions + slack));
array->set(kPrototypeTransitionsIndex, Smi::FromInt(0));
Michael Lippautz 2015/11/27 14:27:28 Do we need to properly initialize the next field?
ulan 2015/11/27 14:43:45 Done. NewTransitionArray() initializes with undef
array->set(kTransitionLengthIndex, Smi::FromInt(number_of_transitions));
@@ -399,10 +399,13 @@ Handle<TransitionArray> TransitionArray::Allocate(Isolate* isolate,
}
-static void ZapTransitionArray(TransitionArray* transitions) {
- MemsetPointer(transitions->data_start(),
+// static
+void TransitionArray::ZapTransitionArray(TransitionArray* transitions) {
+ // Do not zap the next link that is used by GC.
+ STATIC_ASSERT(kNextLinkIndex + 1 == kPrototypeTransitionsIndex);
+ MemsetPointer(transitions->data_start() + kPrototypeTransitionsIndex,
transitions->GetHeap()->the_hole_value(),
- transitions->length());
+ transitions->length() - kPrototypeTransitionsIndex);
}
« src/transitions.h ('K') | « src/transitions.h ('k') | src/transitions-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698