Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1480853002: Check for jsruntime before comparing with default super runtime function (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Check for jsruntime before comparing with default super runtime function BUG=chromium:561975 LOG=n Committed: https://crrev.com/8b192a2a30b0b9d563cb3a31b1d6df4193c0b1b2 Cr-Commit-Position: refs/heads/master@{#32327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M src/prettyprinter.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Toon Verwaest
ptal
5 years ago (2015-11-26 10:04:16 UTC) #2
Igor Sheludko
lgtm
5 years ago (2015-11-26 10:05:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1480853002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1480853002/1
5 years ago (2015-11-26 10:06:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-11-26 10:39:01 UTC) #6
commit-bot: I haz the power
5 years ago (2015-11-26 10:39:48 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b192a2a30b0b9d563cb3a31b1d6df4193c0b1b2
Cr-Commit-Position: refs/heads/master@{#32327}

Powered by Google App Engine
This is Rietveld 408576698