ExtensionSystem cleanup part 3

ExtensionSystem cleanup part 3

Fix most users of ExtensionSystemFactory::GetInstance() to use ExtensionsBrowserClient::Get()->GetExtensionSystemFactory(). Clean up extension_system_factory.h includes.

Follows https://codereview.chromium.org/137753016/

BUG=337707
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251284

[Yoyo Zhou, 2014-02-13 02:07:01]

reviewers:
jamescook: for chrome/browser/extensions
sky: for everything else

https://codereview.chromium.org/148083014/diff/1/extensions/browser/extension...
File extensions/browser/extension_system_provider.cc (right):

https://codereview.chromium.org/148083014/diff/1/extensions/browser/extension...
extensions/browser/extension_system_provider.cc:14: :
BrowserContextKeyedServiceFactory(name, manager) {}
Sorry, this is from a git cl format gone astray. (Should've been in the previous
change.)

[James Cook, 2014-02-13 17:02:36]

c/b/extensions LGTM

[sky, 2014-02-13 18:13:36]

LGTM

[Yoyo Zhou, 2014-02-13 18:13:57]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:15:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/1

[commit-bot: I haz the power, 2014-02-13 18:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:15:51]

Failed to apply patch for
chrome/browser/extensions/api/system_info/system_info_api.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/extensions/api/system_info/system_info_api.cc
  Hunk #1 FAILED at 20.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/extensions/api/system_info/system_info_api.cc.rej

Patch:       chrome/browser/extensions/api/system_info/system_info_api.cc
Index: chrome/browser/extensions/api/system_info/system_info_api.cc
diff --git a/chrome/browser/extensions/api/system_info/system_info_api.cc
b/chrome/browser/extensions/api/system_info/system_info_api.cc
index
542cc085f19acfe47c72ec25fa002e93c1c18e9f..24b43cf67f009d0586b3cc6b4d9fb4bf817b1075
100644
--- a/chrome/browser/extensions/api/system_info/system_info_api.cc
+++ b/chrome/browser/extensions/api/system_info/system_info_api.cc
@@ -20,6 +20,7 @@
 #include "chrome/browser/storage_monitor/storage_monitor.h"
 #include "chrome/common/extensions/api/system_display.h"
 #include "chrome/common/extensions/api/system_storage.h"
+#include "extensions/browser/extension_system.h"
 #include "ui/gfx/display_observer.h"
 
 #if defined(OS_CHROMEOS)

[Yoyo Zhou, 2014-02-13 18:22:42]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:25:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/180001

[commit-bot: I haz the power, 2014-02-13 18:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 18:45:47]

Retried try job too often on win_rel for step(s) app_list_unittests,
ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chrome_elf_unittests, chromedriver_unittests,
components_unittests, compositor_unittests, content_browsertests,
content_unittests, crypto_unittests, events_unittests, google_apis_unittests,
gpu_unittests, installer_util_unittests, ipc_tests, jingle_unittests,
media_unittests, mini_installer_test, nacl_integration, ppapi_unittests,
printing_unittests, remoting_unittests, sql_unittests, sync_integration_tests,
sync_unit_tests, telemetry_perf_unittests, telemetry_unittests, views_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Yoyo Zhou, 2014-02-13 19:00:11]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-13 19:02:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/180001

[commit-bot: I haz the power, 2014-02-13 20:00:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/180001

[commit-bot: I haz the power, 2014-02-13 20:27:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 20:28:00]

Commit queue patch verification failed without an error message.
Something went wrong, probably a crash, a hickup or simply
the monkeys went out for dinner.
Please email commit-bot@chromium.org with the CL url.

[Yoyo Zhou, 2014-02-13 21:16:54]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-13 21:18:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/180001

[commit-bot: I haz the power, 2014-02-13 22:27:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 22:27:23]

Retried try job too often on mac_rel for step(s) app_list_unittests,
base_unittests, browser_tests, cacheinvalidation_unittests, cc_unittests,
check_deps, check_deps2git, chromedriver_unittests, components_unittests,
content_browsertests, content_unittests, crypto_unittests,
google_apis_unittests, gpu_unittests, interactive_ui_tests, ipc_tests,
jingle_unittests, media_unittests, message_center_unittests, nacl_integration,
net_unittests, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests,
telemetry_perf_unittests, telemetry_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Yoyo Zhou, 2014-02-14 01:54:59]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-14 01:55:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/610001

[commit-bot: I haz the power, 2014-02-14 02:45:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-14 02:45:39]

Retried try job too often on mac_rel for step(s) app_list_unittests,
cacheinvalidation_unittests, cc_unittests, check_deps, check_deps2git,
chromedriver_unittests, components_unittests, content_browsertests,
content_unittests, crypto_unittests, google_apis_unittests, gpu_unittests,
ipc_tests, jingle_unittests, media_unittests, message_center_unittests,
nacl_integration, ppapi_unittests, printing_unittests, remoting_unittests,
sql_unittests, sync_integration_tests, sync_unit_tests,
telemetry_perf_unittests, telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[Yoyo Zhou, 2014-02-14 07:24:06]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-02-14 07:25:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yoz@chromium.org/148083014/870001

[commit-bot: I haz the power, 2014-02-14 13:33:41]

Change committed as 251284