content/browser/frame_host/render_frame_host_manager_unittest.cc - Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager_unittest.cc

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix ASAN builds. Try 2. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_host_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.h » ('j') | content/browser/renderer_host/render_view_host_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/frame_host/render_frame_host_manager_unittest.cc

diff --git a/content/browser/frame_host/render_frame_host_manager_unittest.cc b/content/browser/frame_host/render_frame_host_manager_unittest.cc

index 40eea0b129377afc73a4bd7008d3376198f72d49..199a217f8a0d8a2abda607f91cdf8d5fe1fd4cfb 100644

--- a/content/browser/frame_host/render_frame_host_manager_unittest.cc

+++ b/content/browser/frame_host/render_frame_host_manager_unittest.cc

@@ -755,7 +755,7 @@ TEST_F(RenderFrameHostManagerTest, NavigateWithEarlyReNavigation) {

test_process_host2->sink().ClearMessages();

host2->render_view_host()->NavigateToURL(kUrl2);

EXPECT_FALSE(test_process_host2->sink().GetUniqueMessageMatching(

- ViewMsg_Navigate::ID));

+ FrameMsg_Navigate::ID));

// Allow closing the current Render View (precondition for swapping out

// the RVH): Simulate response from RenderView for ViewMsg_ShouldClose sent by

@@ -782,7 +782,7 @@ TEST_F(RenderFrameHostManagerTest, NavigateWithEarlyReNavigation) {

EXPECT_EQ(host2, manager->pending_frame_host());

// There should be still no navigation messages being sent.

EXPECT_FALSE(test_process_host2->sink().GetUniqueMessageMatching(

- ViewMsg_Navigate::ID));

+ FrameMsg_Navigate::ID));

// 3) Cross-site navigate to next site before 2) has committed. --------------

const GURL kUrl3("http://webkit.org/");