Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix ASAN builds. Try 2. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 3ea59fa06ecf6646398d097c930e414d2dfd7d44..20610a915fd81e23cc3c6cc5ddbc94d300e8511a 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -15,6 +15,7 @@
class GURL;
struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
+struct FrameMsg_Navigate_Params;
namespace base {
class FilePath;
@@ -93,6 +94,18 @@ class CONTENT_EXPORT RenderFrameHostImpl : public RenderFrameHost {
// call it directly. It should be made private once Navigate moves here.
void OnDidStartLoading();
+ // Sends the given navigation message. Use this rather than sending it
+ // yourself since this does the internal bookkeeping described below. This
+ // function takes ownership of the provided message pointer.
+ //
+ // If a cross-site request is in progress, we may be suspended while waiting
+ // for the onbeforeunload handler, so this function might buffer the message
+ // rather than sending it.
+ void Navigate(const FrameMsg_Navigate_Params& params);
+
+ // Load the specified URL, this is a shortcut for Navigate().
Charlie Reis 2014/02/13 01:23:53 nit: As long as we're moving it, let's change the
nasko 2014/02/13 17:05:27 Done.
+ void NavigateToURL(const GURL& url);
+
protected:
friend class RenderFrameHostFactory;

Powered by Google App Engine
This is Rietveld 408576698