Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: content/browser/frame_host/navigator_impl.cc

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another one bites the dust. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigator_impl.cc
diff --git a/content/browser/frame_host/navigator_impl.cc b/content/browser/frame_host/navigator_impl.cc
index 97985834917ca936e0c7e5e1ce7df0837ba53163..f01dc531fca5073272ebf8e64a56d9a65e265bc1 100644
--- a/content/browser/frame_host/navigator_impl.cc
+++ b/content/browser/frame_host/navigator_impl.cc
@@ -32,16 +32,16 @@ namespace content {
namespace {
-ViewMsg_Navigate_Type::Value GetNavigationType(
+FrameMsg_Navigate_Type::Value GetNavigationType(
BrowserContext* browser_context, const NavigationEntryImpl& entry,
NavigationController::ReloadType reload_type) {
switch (reload_type) {
case NavigationControllerImpl::RELOAD:
- return ViewMsg_Navigate_Type::RELOAD;
+ return FrameMsg_Navigate_Type::RELOAD;
case NavigationControllerImpl::RELOAD_IGNORING_CACHE:
- return ViewMsg_Navigate_Type::RELOAD_IGNORING_CACHE;
+ return FrameMsg_Navigate_Type::RELOAD_IGNORING_CACHE;
case NavigationControllerImpl::RELOAD_ORIGINAL_REQUEST_URL:
- return ViewMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL;
+ return FrameMsg_Navigate_Type::RELOAD_ORIGINAL_REQUEST_URL;
case NavigationControllerImpl::NO_RELOAD:
break; // Fall through to rest of function.
}
@@ -51,17 +51,17 @@ ViewMsg_Navigate_Type::Value GetNavigationType(
if (entry.restore_type() ==
NavigationEntryImpl::RESTORE_LAST_SESSION_EXITED_CLEANLY) {
if (entry.GetHasPostData())
- return ViewMsg_Navigate_Type::RESTORE_WITH_POST;
- return ViewMsg_Navigate_Type::RESTORE;
+ return FrameMsg_Navigate_Type::RESTORE_WITH_POST;
+ return FrameMsg_Navigate_Type::RESTORE;
}
- return ViewMsg_Navigate_Type::NORMAL;
+ return FrameMsg_Navigate_Type::NORMAL;
}
void MakeNavigateParams(const NavigationEntryImpl& entry,
const NavigationControllerImpl& controller,
NavigationController::ReloadType reload_type,
- ViewMsg_Navigate_Params* params) {
+ FrameMsg_Navigate_Params* params) {
params->page_id = entry.GetPageID();
params->should_clear_history_list = entry.should_clear_history_list();
params->should_replace_current_entry = entry.should_replace_entry();
@@ -334,13 +334,13 @@ bool NavigatorImpl::NavigateToEntry(
// Used for page load time metrics.
current_load_start_ = base::TimeTicks::Now();
- // Navigate in the desired RenderViewHost.
+ // Navigate in the desired RenderFrameHost.
// TODO(creis): As a temporary hack, we currently do cross-process subframe
// navigations in a top-level frame of the new process. Thus, we don't yet
- // need to store the correct frame ID in ViewMsg_Navigate_Params.
- ViewMsg_Navigate_Params navigate_params;
+ // need to store the correct frame ID in FrameMsg_Navigate_Params.
+ FrameMsg_Navigate_Params navigate_params;
MakeNavigateParams(entry, *controller_, reload_type, &navigate_params);
- dest_render_frame_host->render_view_host()->Navigate(navigate_params);
+ dest_render_frame_host->Navigate(navigate_params);
if (entry.GetPageID() == -1) {
// HACK!! This code suppresses javascript: URLs from being added to
« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698