Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 148083013: Move browser initiated navigation from RenderViewHost to RenderFrameHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Another one bites the dust. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/callback.h" 10 #include "base/callback.h"
11 #include "base/compiler_specific.h" 11 #include "base/compiler_specific.h"
12 #include "base/strings/string16.h" 12 #include "base/strings/string16.h"
13 #include "content/common/content_export.h" 13 #include "content/common/content_export.h"
14 #include "content/public/browser/render_frame_host.h" 14 #include "content/public/browser/render_frame_host.h"
15 15
16 class GURL; 16 class GURL;
17 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params; 17 struct FrameHostMsg_DidFailProvisionalLoadWithError_Params;
18 struct FrameMsg_Navigate_Params;
18 19
19 namespace base { 20 namespace base {
20 class FilePath; 21 class FilePath;
21 } 22 }
22 23
23 namespace content { 24 namespace content {
24 25
25 class CrossProcessFrameConnector; 26 class CrossProcessFrameConnector;
26 class FrameTree; 27 class FrameTree;
27 class FrameTreeNode; 28 class FrameTreeNode;
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 } 87 }
87 88
88 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called 89 // Sets the RVH for |this| as pending shutdown. |on_swap_out| will be called
89 // when the SwapOutACK is received. 90 // when the SwapOutACK is received.
90 void SetPendingShutdown(const base::Closure& on_swap_out); 91 void SetPendingShutdown(const base::Closure& on_swap_out);
91 92
92 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can 93 // TODO(nasko): This method is public so RenderViewHostImpl::Navigate can
93 // call it directly. It should be made private once Navigate moves here. 94 // call it directly. It should be made private once Navigate moves here.
94 void OnDidStartLoading(); 95 void OnDidStartLoading();
95 96
97 // Sends the given navigation message. Use this rather than sending it
98 // yourself since this does the internal bookkeeping described below. This
99 // function takes ownership of the provided message pointer.
100 //
101 // If a cross-site request is in progress, we may be suspended while waiting
102 // for the onbeforeunload handler, so this function might buffer the message
103 // rather than sending it.
104 void Navigate(const FrameMsg_Navigate_Params& params);
105
106 // Load the specified URL; this is a shortcut for Navigate().
107 void NavigateToURL(const GURL& url);
108
96 protected: 109 protected:
97 friend class RenderFrameHostFactory; 110 friend class RenderFrameHostFactory;
98 111
99 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost 112 // TODO(nasko): Remove dependency on RenderViewHost here. RenderProcessHost
100 // should be the abstraction needed here, but we need RenderViewHost to pass 113 // should be the abstraction needed here, but we need RenderViewHost to pass
101 // into WebContentsObserver::FrameDetached for now. 114 // into WebContentsObserver::FrameDetached for now.
102 RenderFrameHostImpl(RenderViewHostImpl* render_view_host, 115 RenderFrameHostImpl(RenderViewHostImpl* render_view_host,
103 RenderFrameHostDelegate* delegate, 116 RenderFrameHostDelegate* delegate,
104 FrameTree* frame_tree, 117 FrameTree* frame_tree,
105 FrameTreeNode* frame_tree_node, 118 FrameTreeNode* frame_tree_node,
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 182
170 int routing_id_; 183 int routing_id_;
171 bool is_swapped_out_; 184 bool is_swapped_out_;
172 185
173 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 186 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
174 }; 187 };
175 188
176 } // namespace content 189 } // namespace content
177 190
178 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 191 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698