Issue 14807009: Merge 198744 "Fix security errors when accessing files and volum..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14807009: Merge 198744 "Fix security errors when accessing files and volum..." (Closed)

Created:
7 years, 7 months ago by mtomasz

Modified:
7 years, 7 months ago

Reviewers:
mtomasz

CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1500/src/

Visibility:
Public.

More Reviews

Description

Merge 198744 "Fix security errors when accessing files and volum..." > Fix security errors when accessing files and volumes in Files.app V2 due to using unregistered handlers. > > The security errors were caused by revoking permissions to a file, directory or a root directory of a volume caused by launching Files.app using a handler not declared in the manifest. This patch fixes this issue by declaring all used handlers in the manifests and disallowing of calling undeclared handlers. > > TEST=Check these bugs' repro steps. > BUG=233641, 237134, 236743, 238239, 234056 > > Review URL: https://chromiumcodereview.appspot.com/14864004 TBR=mtomasz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199670

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -9 lines)			Patch
M	chrome/browser/chromeos/extensions/file_manager/file_handler_util.cc	View	3 chunks	+14 lines, -9 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest.json	View	1 chunk	+29 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/file_manager/manifest_new_ui.json	View	1 chunk	+29 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r199670.

Expand Messages | Collapse Messages